Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloading build artifact in case build is triggered from forked… #10297

Merged
merged 4 commits into from
May 6, 2019
Merged

Fix downloading build artifact in case build is triggered from forked… #10297

merged 4 commits into from
May 6, 2019

Conversation

omeshp
Copy link
Contributor

@omeshp omeshp commented May 2, 2019

… github repos.

@omeshp omeshp requested a review from Lovakumar as a code owner May 2, 2019 13:18
This was referenced May 2, 2019
Closed
Closed
Lovakumar
Lovakumar approved these changes May 6, 2019
View reviewed changes
Tasks/DownloadBuildArtifactsV0/task.json
@@ -239,6 +239,7 @@
"DownloadArtifacts": "Downloading artifact %s from: %s",
"DownloadingArtifactsForBuild": "Downloading artifacts for build: %s",
"LinkedArtifactCount": "Linked artifacts count: %s",
"ExtractionFailed": "Failed to extract package with error %s",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package extraction failed with error %s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take separately

@omeshp omeshp merged commit 5c6d88f into master May 6, 2019
@rozele
Copy link

rozele commented Jun 19, 2019 •
edited
Loading

I'm currently getting 404s when using the DownloadBuildArtifacts task in my Azure Pipeline:
https://dev.azure.com/NLUDevOps/NLU.DevOps/_build/results?buildId=62

The build is triggered by a PR from a fork on GitHub. Does this PR resolve the issue, and if so any ETA on when it will be pushed to production?

@Lovakumar
Copy link
Contributor

I'm currently getting 404s when using the DownloadBuildArtifacts task in my Azure Pipeline:
https://dev.azure.com/NLUDevOps/NLU.DevOps/_build/results?buildId=62

The build is triggered by a PR from a fork on GitHub. Does this PR resolve the issue, and if so any ETA on when it will be pushed to production?

This fix is already in production. Please try and let us know if it's not working for you.

@rozele
Copy link

rozele commented Jun 20, 2019

Thanks @Lovakumar - sent you mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lovakumar Lovakumar Lovakumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omeshp @rozele @Lovakumar