Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing downloadPath to targetPath and couple of other fields to match V0 #10059

Conversation

fadnavistanmay
Copy link
Contributor

Changing targetPath to downloadPath and couple of other fields to match V0 version od the task

@fadnavistanmay
Copy link
Contributor Author

@owenhuynMSFT

@fadnavistanmay fadnavistanmay changed the title Changing targetPath to downloadPath and couple of other fields to match V0 Changing downloadPath to targetPath and couple of other fields to match V0 Apr 8, 2019
@stephenmichaelf
Copy link
Member

Is this a breaking change that needs major version bump?

@fadnavistanmay
Copy link
Contributor Author

Is this a breaking change that needs major version bump?

Hi Stephen, we have made sure that the agent is backcompatible , so just a new patch should do.

Copy link
Member

@stephenmichaelf stephenmichaelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving for permissions, this task is owned by the team making the changes and was reviewed by them.

@stephenmichaelf stephenmichaelf merged commit e239620 into microsoft:master Apr 24, 2019
fadnavistanmay added a commit to fadnavistanmay/azure-pipelines-tasks that referenced this pull request Apr 25, 2019
…ch V0 (microsoft#10059)

* Adding aliases to targetpath

* Chaning patch for Download Pipeline Artifact V1 task

* PR comments

* Fixing version for PublishPipelineArtifact task as well

* Version fix
fadnavistanmay added a commit to fadnavistanmay/azure-pipelines-tasks that referenced this pull request Apr 25, 2019
arunkm pushed a commit that referenced this pull request Apr 25, 2019
…ch V0 (#10059) (#10214)

* Adding aliases to targetpath

* Chaning patch for Download Pipeline Artifact V1 task

* PR comments

* Fixing version for PublishPipelineArtifact task as well

* Version fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants