Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven build job on PR can't find report-task.txt #3976

Closed
ratcashdev opened this issue Apr 10, 2017 · 6 comments
Closed

maven build job on PR can't find report-task.txt #3976

ratcashdev opened this issue Apr 10, 2017 · 6 comments

Comments

@ratcashdev
Copy link

Using VSTS 2017 and Sonarqube 6.x
PR jobs are started with -Dsonar.analysis.mode=issues hence sonar does not generate the report-task.txt. The build does not find it, and consider the sonar analysis broken. As a result the PR is not populated with sonar analysis result's comments.

@ericsciple
Copy link
Contributor

Sonar integration is a third party extension (not this repo)

@ericsciple
Copy link
Contributor

@davidstaheli to verify i'm not overlooking something (since this is a Maven build). I think this issue should be closed here and follow with Sonar folks would be best.

@ratcashdev
Copy link
Author

ratcashdev commented Apr 11, 2017

Just mentioning, that while we do have installed the extension from SONAR (3rd party), it does not look like the maven job was replaced (yet) by the Sonar folks - I know the MS Build tasks are already deprecated because of this.

@ratcashdev
Copy link
Author

ratcashdev commented Apr 20, 2017

Note that the above happens with Include full analysis report in the build summary (SQ 5.3+) enabled but without Fail the build on quality gate failure (SQ 5.3+) being active. I'd assume, that report-task.txt is only needed for quality gate failure, but not for the Include full analysis report in the build summary (SQ 5.3+) because that is inside the sonar-report.json, since the job is started with -Dsonar.report.export.path=sonar-report.json.

@ratcashdev
Copy link
Author

FYI, after checking the sources, it seems it's really https://github.com/Microsoft/vsts-tasks/tree/master/Tasks/Maven that currently provides this functionality for maven.

@davidstaheli davidstaheli assigned leantk and lkillgore and unassigned davidstaheli Jun 8, 2017
jpricket added a commit that referenced this issue Jun 16, 2017
even in PR builds
Fixing issue #3976
Internal Bug #976726
jpricket added a commit that referenced this issue Jun 16, 2017
even in PR builds
Fixing issue #3976
Internal Bug #976726
@lkillgore
Copy link
Contributor

Hi @ratcashdev, we made some changes recently, and I believe this is currently set to the behavior you're requesting, so I'm closing this ticket. If that's not the case or if need a change in functionality, please open a new ticket for our consideration. Thanks!

(Additionally, we've asked SonarQube to take over the development of the SonarQube logic, so this may change in the future.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants