[AzureRGDeploy] Sanitizing parameters bug fix (#6349)

* [AzureRGDeploy] Sanitization bug fix * Fixing getError * Revert "Fixing getError" This reverts commit 506497e.
microsoft · Feb 2, 2018 · f89fa98 · f89fa98
1 parent 7cde369
commit f89fa98
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/Tasks/AzureResourceGroupDeployment/Tests/CSM.json b/Tasks/AzureResourceGroupDeployment/Tests/CSM.json
@@ -1,7 +1,7 @@
 {
     "parameters": {
         "param": {
-            "value": 1,
+            "value": false,
             "toBeRemoved": true
         }
     }

diff --git a/Tasks/AzureResourceGroupDeployment/operations/ResourceGroup.ts b/Tasks/AzureResourceGroupDeployment/operations/ResourceGroup.ts
@@ -379,14 +379,16 @@ export class ResourceGroup {
     private sanitizeParameters(parameters: Map<string, ParameterValue>): Map<string, ParameterValue> {
         var result: Map<string, ParameterValue> = {} as Map<string, ParameterValue>;
         for (var key in parameters) {
-            if (!!parameters[key].value) {
-                result[key] = {
-                    value: parameters[key].value
-                } as ParameterValue;
-            } else if (!!parameters[key].reference) {
-                result[key] = {
-                    reference: parameters[key].reference
-                } as ParameterValue;
+            if (!!parameters[key]) {
+                if (parameters[key].hasOwnProperty("value")) {
+                    result[key] = {
+                        value: parameters[key].value
+                    } as ParameterValue;
+                } else if (parameters[key].hasOwnProperty("reference")) {
+                    result[key] = {
+                        reference: parameters[key].reference
+                    } as ParameterValue;
+                }
             }
         }
 

diff --git a/Tasks/AzureResourceGroupDeployment/task.json b/Tasks/AzureResourceGroupDeployment/task.json
@@ -14,7 +14,7 @@
     "version": {
         "Major": 2,
         "Minor": 129,
-        "Patch": 3
+        "Patch": 4
     },
     "demands": [],
     "minimumAgentVersion": "2.119.1",

diff --git a/Tasks/AzureResourceGroupDeployment/task.loc.json b/Tasks/AzureResourceGroupDeployment/task.loc.json
@@ -14,7 +14,7 @@
   "version": {
     "Major": 2,
     "Minor": 129,
-    "Patch": 3
+    "Patch": 4
   },
   "demands": [],
   "minimumAgentVersion": "2.119.1",