Updating node to node 10 in tasks (#14019)

* Updating node to node 10 in tasks * Replacing deprecated MochaDone with Mocha.Done * Update common packages versions * Adding DockerV2 version changes * Updating docker-common-v2 version
microsoft · Dec 30, 2020 · f720782 · f720782
1 parent 6ae75ce
commit f720782
Show file tree

Hide file tree

Showing 35 changed files with 3,488 additions and 511 deletions.
diff --git a/Tasks/DockerV2/Tests/L0.ts b/Tasks/DockerV2/Tests/L0.ts
diff --git a/Tasks/DockerV2/package-lock.json b/Tasks/DockerV2/package-lock.json
diff --git a/Tasks/DockerV2/package.json b/Tasks/DockerV2/package.json
@@ -1,12 +1,17 @@
 {
   "dependencies": {
-    "@types/mocha": "^2.2.5",
-    "@types/node": "^6.0.101",
+    "@types/mocha": "^5.2.7",
+    "@types/node": "^10.17.0",
     "@types/q": "^1.5.0",
-    "azure-pipelines-tasks-docker-common-v2": "1.0.0",
+    "@types/uuid": "^8.3.0",
+    "azure-pipelines-task-lib": "^3.0.6-preview.0",
+    "azure-pipelines-tasks-docker-common-v2": "2.0.1-preview.0",
     "del": "2.2.0",
     "esprima": "2.7.1",
     "js-yaml": "3.6.1",
     "utility-common-v2": "file:../../_build/Tasks/Common/utility-common-v2-2.0.0.tgz"
+  },
+  "devDependencies": {
+    "typescript": "4.0.2"
   }
 }
diff --git a/Tasks/DockerV2/task.json b/Tasks/DockerV2/task.json
@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 2,
-        "Minor": 176,
+        "Minor": 181,
         "Patch": 0
     },
     "minimumAgentVersion": "2.172.0",
@@ -139,7 +139,7 @@
     "instanceNameFormat": "$(command)",
     "showEnvironmentVariables": true,
     "execution": {
-        "Node": {
+        "Node10": {
             "target": "docker.js"
         }
     },

diff --git a/Tasks/DockerV2/task.loc.json b/Tasks/DockerV2/task.loc.json
@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 176,
+    "Minor": 181,
     "Patch": 0
   },
   "minimumAgentVersion": "2.172.0",
@@ -139,7 +139,7 @@
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",
   "showEnvironmentVariables": true,
   "execution": {
-    "Node": {
+    "Node10": {
       "target": "docker.js"
     }
   },

diff --git a/Tasks/HelmDeployV0/Tests/L0.ts b/Tasks/HelmDeployV0/Tests/L0.ts
@@ -34,7 +34,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 3) with chart name", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 3) with chart name", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -56,7 +56,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 3) with chart name when publishPipelineMetadata is set to false", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 3) with chart name when publishPipelineMetadata is set to false", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -78,7 +78,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 2) with chart name", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 2) with chart name", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -98,7 +98,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 3) with chart path", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 3) with chart path", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -118,7 +118,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 3) when release name is not given", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 3) when release name is not given", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -137,7 +137,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm install (version 3) when invalid chart version is given", function (done: MochaDone) {
+    it("Run successfully with Helm install (version 3) when invalid chart version is given", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -158,7 +158,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm upgrade (version 3) when chart name is given and release name is not", function (done: MochaDone) {
+    it("Run successfully with Helm upgrade (version 3) when chart name is given and release name is not", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -176,7 +176,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm upgrade (version 3) when chart name and release name are given", function (done: MochaDone) {
+    it("Run successfully with Helm upgrade (version 3) when chart name and release name are given", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -195,7 +195,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm init (version 2)", function (done: MochaDone) {
+    it("Run successfully with Helm init (version 2)", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -208,7 +208,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Helm init should fail (version 3)", function (done: MochaDone) {
+    it("Helm init should fail (version 3)", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -222,7 +222,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm package command (version 3)", function (done: MochaDone) {
+    it("Run successfully with Helm package command (version 3)", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -239,7 +239,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Run successfully with Helm save command (version 3)", function (done: MochaDone) {
+    it("Run successfully with Helm save command (version 3)", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.command] = shared.Commands.save;
@@ -261,7 +261,7 @@ describe("HelmDeployV0 Suite", function () {
         done();
     });
 
-    it("Helm same should fail (version 2)", function (done: MochaDone) {
+    it("Helm same should fail (version 2)", function (done: Mocha.Done) {
         const tp = path.join(__dirname, "TestSetup.js");
         const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
         process.env[shared.TestEnvVars.command] = shared.Commands.save;