Fixed null reference error while getting registry urls (#10782)

* Fixed null reference error while getting registry urls * Fixed EOF for unchanged tasks * Bumped common task versions
microsoft · Nov 15, 2019 · f0bf16d · f0bf16d
1 parent 648307f
commit f0bf16d
Show file tree

Hide file tree

Showing 35 changed files with 52 additions and 49 deletions.
diff --git a/Tasks/Common/packaging-common/npm/npmutil.ts b/Tasks/Common/packaging-common/npm/npmutil.ts
@@ -17,7 +17,7 @@ export function appendToNpmrc(npmrc: string, data: string): void {
 export async function getLocalRegistries(packagingUrls: string[], npmrc: string): Promise<string[]> {
     const collectionHosts = packagingUrls.map((pkgUrl: string) => {
         const parsedUrl = url.parse(pkgUrl);
-        if (parsedUrl) {
+        if (parsedUrl && parsedUrl.host) {
             return parsedUrl.host.toLowerCase();
         }
         return undefined;
@@ -26,8 +26,11 @@ export async function getLocalRegistries(packagingUrls: string[], npmrc: string)
     const registries = NpmrcParser.GetRegistries(npmrc, /* saveNormalizedRegistries */ true);
 
     const localRegistries = registries.filter(registry => {
-        const registryHost = url.parse(registry).host;
-        return collectionHosts.indexOf(registryHost.toLowerCase()) >= 0;
+        const registryUrl = url.parse(registry);
+        if(registryUrl && registryUrl.host) {
+            return collectionHosts.indexOf(registryUrl.host.toLowerCase()) >= 0;
+        }
+        return undefined;
     });
 
     tl.debug(tl.loc('FoundLocalRegistries', localRegistries.length));

diff --git a/Tasks/DotNetCoreCLIV2/task.json b/Tasks/DotNetCoreCLIV2/task.json
@@ -17,7 +17,7 @@
     "demands": [],
     "version": {
         "Major": 2,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "minimumAgentVersion": "2.115.0",

diff --git a/Tasks/DotNetCoreCLIV2/task.loc.json b/Tasks/DotNetCoreCLIV2/task.loc.json
@@ -17,7 +17,7 @@
   "demands": [],
   "version": {
     "Major": 2,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "minimumAgentVersion": "2.115.0",

diff --git a/Tasks/DownloadPackageV0/task.json b/Tasks/DownloadPackageV0/task.json
@@ -9,7 +9,7 @@
     "author": "ms-vscs-rm",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "demands": [],

diff --git a/Tasks/DownloadPackageV0/task.loc.json b/Tasks/DownloadPackageV0/task.loc.json
@@ -9,7 +9,7 @@
   "author": "ms-vscs-rm",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "demands": [],
@@ -107,4 +107,4 @@
     "OperationFailed": "ms-resource:loc.messages.OperationFailed",
     "UnsupportedProjectScopedFeeds": "ms-resource:loc.messages.UnsupportedProjectScopedFeeds"
   }
-}
+}
diff --git a/Tasks/DownloadPackageV1/task.json b/Tasks/DownloadPackageV1/task.json
@@ -10,7 +10,7 @@
     "version": {
         "Major": 1,
         "Minor": 161,
-        "Patch": 0
+        "Patch": 1
     },
     "demands": [],
     "releaseNotes": "Adds support to download Maven, Python, Universal and Npm packages.",

diff --git a/Tasks/DownloadPackageV1/task.loc.json b/Tasks/DownloadPackageV1/task.loc.json
@@ -10,7 +10,7 @@
   "version": {
     "Major": 1,
     "Minor": 161,
-    "Patch": 0
+    "Patch": 1
   },
   "demands": [],
   "releaseNotes": "ms-resource:loc.releaseNotes",
@@ -186,4 +186,4 @@
     "Info_Downloading": "ms-resource:loc.messages.Info_Downloading",
     "Info_UsingArtifactToolDownload": "ms-resource:loc.messages.Info_UsingArtifactToolDownload"
   }
-}
+}
diff --git a/Tasks/MavenV2/task.json b/Tasks/MavenV2/task.json
@@ -17,7 +17,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 2,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",

diff --git a/Tasks/MavenV2/task.loc.json b/Tasks/MavenV2/task.loc.json
@@ -17,7 +17,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",
@@ -409,4 +409,4 @@
     "AuthenticationNotNecessary": "ms-resource:loc.messages.AuthenticationNotNecessary",
     "UsingAuthFeed": "ms-resource:loc.messages.UsingAuthFeed"
   }
-}
+}
diff --git a/Tasks/MavenV3/task.json b/Tasks/MavenV3/task.json
@@ -17,7 +17,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 3,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",

diff --git a/Tasks/MavenV3/task.loc.json b/Tasks/MavenV3/task.loc.json
@@ -17,7 +17,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",

diff --git a/Tasks/NpmAuthenticateV0/task.json b/Tasks/NpmAuthenticateV0/task.json
@@ -9,7 +9,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/NpmAuthenticateV0/task.loc.json b/Tasks/NpmAuthenticateV0/task.loc.json
@@ -9,7 +9,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [
@@ -66,4 +66,4 @@
       "argumentFormat": ""
     }
   }
-}
+}
diff --git a/Tasks/NpmV1/task.json b/Tasks/NpmV1/task.json
@@ -9,7 +9,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/NpmV1/task.loc.json b/Tasks/NpmV1/task.loc.json
@@ -9,7 +9,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [

diff --git a/Tasks/NuGetCommandV2/task.json b/Tasks/NuGetCommandV2/task.json
@@ -10,7 +10,7 @@
     "version": {
         "Major": 2,
         "Minor": 161,
-        "Patch": 0
+        "Patch": 1
     },
     "runsOn": [
         "Agent",

diff --git a/Tasks/NuGetCommandV2/task.loc.json b/Tasks/NuGetCommandV2/task.loc.json
@@ -10,7 +10,7 @@
   "version": {
     "Major": 2,
     "Minor": 161,
-    "Patch": 0
+    "Patch": 1
   },
   "runsOn": [
     "Agent",
@@ -535,4 +535,4 @@
     "Warning_UpdatingNuGetVersion": "ms-resource:loc.messages.Warning_UpdatingNuGetVersion",
     "Error_NugetFailedWithCodeAndErr": "ms-resource:loc.messages.Error_NugetFailedWithCodeAndErr"
   }
-}
+}
diff --git a/Tasks/NuGetPublisherV0/task.json b/Tasks/NuGetPublisherV0/task.json
@@ -9,7 +9,7 @@
     "author": "Lawrence Gripper",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/NuGetPublisherV0/task.loc.json b/Tasks/NuGetPublisherV0/task.loc.json
@@ -9,7 +9,7 @@
   "author": "Lawrence Gripper",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [

diff --git a/Tasks/NuGetToolInstallerV0/task.json b/Tasks/NuGetToolInstallerV0/task.json
@@ -14,7 +14,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "preview": false,

diff --git a/Tasks/NuGetToolInstallerV0/task.loc.json b/Tasks/NuGetToolInstallerV0/task.loc.json
@@ -14,7 +14,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "preview": false,
@@ -75,4 +75,4 @@
     "NGCommon_UnableToFindTool": "ms-resource:loc.messages.NGCommon_UnableToFindTool",
     "Warning_UpdatingNuGetVersion": "ms-resource:loc.messages.Warning_UpdatingNuGetVersion"
   }
-}
+}
diff --git a/Tasks/NuGetToolInstallerV1/task.json b/Tasks/NuGetToolInstallerV1/task.json
@@ -14,7 +14,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "preview": false,

diff --git a/Tasks/NuGetToolInstallerV1/task.loc.json b/Tasks/NuGetToolInstallerV1/task.loc.json
@@ -14,7 +14,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "preview": false,
@@ -83,4 +83,4 @@
     "NGCommon_UnableToFindTool": "ms-resource:loc.messages.NGCommon_UnableToFindTool",
     "Warning_UpdatingNuGetVersion": "ms-resource:loc.messages.Warning_UpdatingNuGetVersion"
   }
-}
+}
diff --git a/Tasks/NuGetV0/task.json b/Tasks/NuGetV0/task.json
@@ -10,7 +10,7 @@
     "helpMarkDown": "",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/NuGetV0/task.loc.json b/Tasks/NuGetV0/task.loc.json
@@ -10,7 +10,7 @@
   "helpMarkDown": "ms-resource:loc.helpMarkDown",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [

diff --git a/Tasks/PipAuthenticateV0/task.json b/Tasks/PipAuthenticateV0/task.json
@@ -9,7 +9,7 @@
     "category": "Package",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/PipAuthenticateV0/task.loc.json b/Tasks/PipAuthenticateV0/task.loc.json
@@ -9,7 +9,7 @@
   "category": "Package",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [
@@ -86,4 +86,4 @@
     "Warn_TooManyFeedEntries": "ms-resource:loc.messages.Warn_TooManyFeedEntries",
     "Warning_SessionCreationFailed": "ms-resource:loc.messages.Warning_SessionCreationFailed"
   }
-}
+}
diff --git a/Tasks/TwineAuthenticateV0/task.json b/Tasks/TwineAuthenticateV0/task.json
@@ -9,7 +9,7 @@
     "category": "Package",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/TwineAuthenticateV0/task.loc.json b/Tasks/TwineAuthenticateV0/task.loc.json
@@ -9,7 +9,7 @@
   "category": "Package",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [
@@ -111,4 +111,4 @@
       "argumentFormat": ""
     }
   }
-}
+}
diff --git a/Tasks/UniversalPackagesV0/task.json b/Tasks/UniversalPackagesV0/task.json
@@ -9,7 +9,7 @@
     "category": "Package",
     "version": {
         "Major": 0,
-        "Minor": 160,
+        "Minor": 161,
         "Patch": 0
     },
     "runsOn": [

diff --git a/Tasks/UniversalPackagesV0/task.loc.json b/Tasks/UniversalPackagesV0/task.loc.json
@@ -9,7 +9,7 @@
   "category": "Package",
   "version": {
     "Major": 0,
-    "Minor": 160,
+    "Minor": 161,
     "Patch": 0
   },
   "runsOn": [

diff --git a/Tasks/UseDotNetV2/task.json b/Tasks/UseDotNetV2/task.json
@@ -14,7 +14,7 @@
     "version": {
         "Major": 2,
         "Minor": 0,
-        "Patch": 24
+        "Patch": 25
     },
    "satisfies": [
         "DotNetCore"

diff --git a/Tasks/UseDotNetV2/task.loc.json b/Tasks/UseDotNetV2/task.loc.json
@@ -14,7 +14,7 @@
   "version": {
     "Major": 2,
     "Minor": 0,
-    "Patch": 24
+    "Patch": 25
   },
   "satisfies": [
     "DotNetCore"
@@ -181,4 +181,4 @@
     "OnlyExplicitVersionAllowed": "ms-resource:loc.messages.OnlyExplicitVersionAllowed",
     "SupportPhaseNotPresentInChannel": "ms-resource:loc.messages.SupportPhaseNotPresentInChannel"
   }
-}
+}
diff --git a/Tasks/UseNodeV1/task.json b/Tasks/UseNodeV1/task.json
@@ -16,8 +16,8 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 160,
-        "Patch": 1
+        "Minor": 161,
+        "Patch": 0
     },
     "satisfies": [
         "Node",