[MavenV3] Migrated to Node 10 (#14064)

microsoft · Dec 28, 2020 · e616883 · e616883
1 parent f8b1911
commit e616883
Show file tree

Hide file tree

Showing 18 changed files with 362 additions and 769 deletions.
diff --git a/Tasks/MavenV3/Tests/TestUtils.ts b/Tasks/MavenV3/Tests/TestUtils.ts
@@ -2,9 +2,8 @@ import * as fs from "fs";
 import * as path from "path";
 
 import { TaskMockRunner } from "azure-pipelines-task-lib/mock-run";
-import { FsOptions } from "azure-pipelines-task-lib/task";
 
-import { registerLocationHelpersMock } from 'packaging-common/Tests/MockHelper';
+import { registerLocationHelpersMock } from 'azure-pipelines-tasks-packaging-common/Tests/MockHelper';
 
 export interface MavenTaskInputs {
     mavenVersionSelection?: string;
@@ -88,6 +87,6 @@ export const initializeTest = (taskRunner: TaskMockRunner): void => {
     registerLocationHelpersMock(taskRunner);
 
     // Prevent file writes
-    taskRunner.registerMockExport("writefile", (file: string, data: string | Buffer, options?: string | FsOptions): void => {})
+    taskRunner.registerMockExport("writefile", (file: string, data: string | Buffer, options?: string | fs.WriteFileOptions): void => {})
     taskRunner.registerMockExport("cp", (source: string, dest: string, options?: string, continueOnError?: boolean): void => {})
 }
diff --git a/Tasks/MavenV3/make.json b/Tasks/MavenV3/make.json
diff --git a/Tasks/MavenV3/maventask.ts b/Tasks/MavenV3/maventask.ts
@@ -249,7 +249,7 @@ async function execBuild() {
             console.error(err.message);
             userRunFailed = true; // Record the error and continue
         })
-        .then(function (code) {
+        .then(function (code: any) {
             if (code && code['code'] != 0) {
                 userRunFailed = true;
             }
@@ -358,7 +358,7 @@ function publishJUnitTestResults(testResultsFiles: string) {
 
     var tp = new tl.TestPublisher("JUnit");
     const testRunTitle = tl.getInput('testRunTitle');
-    tp.publish(matchingJUnitResultFiles, true, "", "", testRunTitle, true, TESTRUN_SYSTEM);
+    tp.publish(matchingJUnitResultFiles, 'true', "", "", testRunTitle, 'true', TESTRUN_SYSTEM);
 }
 
 function execEnableCodeCoverage(): Q.Promise<string> {

diff --git a/Tasks/MavenV3/mavenutil.ts b/Tasks/MavenV3/mavenutil.ts
@@ -4,8 +4,8 @@ import path = require('path');
 import fs = require('fs');
 import * as tl from 'azure-pipelines-task-lib/task';
 import * as tr from 'azure-pipelines-task-lib/toolrunner';
-import * as pkgLocationUtils from "packaging-common/locationUtilities";
-import { logError } from 'packaging-common/util';
+import * as pkgLocationUtils from "azure-pipelines-tasks-packaging-common/locationUtilities";
+import { logError } from 'azure-pipelines-tasks-packaging-common/util';
 
 import * as url from "url";
 import * as xml2js from 'xml2js';