Merge pull request #3248 from jmyersmsft/ignoreUnsetBuildConfig

Ignore configurationToPack if it is literally $(BuildConfiguration)

Tasks/NugetPackager/NuGetPackager.ps1

@@ -164,6 +164,22 @@ if (-not $nuGetPath)
     throw (Get-LocalizedString -Key "Unable to locate {0}" -ArgumentList 'nuget.exe')
 }
 
+$allBuildProps = @()
+
+# We set the default to $(BuildConfiguration) so the task works by default with the Visual
+# Studio Build / MSBuild template. Unfortunately, that causes it to *not* work by default
+# with the empty build template, so we just ignore the value if it wasn't substituted with
+# something useful.
+if($configurationToPack -and $configurationToPack -ne '$(BuildConfiguration)')
+{
+    $allBuildProps += @("Configuration=$configurationToPack")
+}
+
+if ($buildProperties)
+{
+    $allBuildProps += @($buildProperties -split ";")
+}
+
 $initialNuGetExtensionsPath = $env:NUGET_EXTENSIONS_PATH
 try
 {
@@ -187,12 +203,12 @@ try
         $slnFolder = $(Get-ItemProperty -Path $fileToPackage -Name 'DirectoryName').DirectoryName
         #Setup Nuget
 
-        $buildProps = "Configuration=$configurationToPack";
-        if ([string]::IsNullOrEmpty($buildProperties) -eq $false)
+        $argsPack = "pack `"$fileToPackage`" -OutputDirectory `"$outputdir`""
+
+        if ($allBuildProps)
         {
-            $buildProps = ($buildProps + ";" + $buildProperties)
+            $argsPack += " -Properties $($allBuildProps -join ";")"
         }
-        $argsPack = "pack `"$fileToPackage`" -OutputDirectory `"$outputdir`" -Properties $buildProps";
 
         if($b_includeReferencedProjects)
         {

Tasks/NugetPackager/task.json

@@ -9,7 +9,7 @@
     "version": {
         "Major": 0,
         "Minor": 1,
-        "Patch": 69
+        "Patch": 70
     },
     "demands": [
         "Cmd"

Tasks/NugetPackager/task.loc.json

@@ -9,7 +9,7 @@
   "version": {
     "Major": 0,
     "Minor": 1,
-    "Patch": 69
+    "Patch": 70
   },
   "demands": [
     "Cmd"