Skip to content

Commit

Permalink
Node20 build configuration (#19008)
Browse files Browse the repository at this point in the history
* Initial changes to skip updating base version of tasks

* version updates

* versioning updates + fxies

* re-use config version if base version hasn't changed

* don't attempt to remove generated directories yet

* fix off by 1

* fixes
ignore readme files

* add gitignore

* update buildconfiggen launch settings

* Adding node20 build configs

* updates

* updates

* skip downgrade check for node upgrade

* ci

* updates from merges

* skip version check

* add UseDotNetV2

* fix inconsistency

* fix

* ci

* Sync again

* ci

* ci

* [syncGeneratedFilesWrapper] Fix syncGeneratedFilesWrapper

- Fixed cases when the generated files already were in changes

* fixes

* fix

* cleanup

* ci

* fix

* remove gradlev2 as tests fail (to be investigated)

* remove tasks with failing tests

* ci

* don't unnecessarily touch task.json

* remove InstallAppleCertificate for now

* remove InstallAppleProvisioningProfileV1 for now

* Remove InstallSSHKeyV0

* remove msbuildv1

* merge updates

* remove NodeToolV0

* ci

* remove PowerShellV0

* remove SSHV0

* Remove UseNodeV1

* remove UseDotNetV2 / UseNodeV1

* exclude changes in _buildConfigs from triggering version check

* remove uneeded change

* fix

* ci

* Revert "ci"

This reverts commit 4369f27.

* ci

* merge

* merge

* ci

* fix for quoting issue

* another quoting fix attempt

* another quoting fix

* remove JavaToolInstallerV0

* fix

* include generated tasks in version check

* ci

* fix

* ci

* remove attempt to check downgrading on changed generated tasks  -- as it doesn't currently work

---------

Co-authored-by: Dmitrii Bobreshev (Akvelon INC) <[email protected]>
  • Loading branch information
merlynomsft and DmitriiBobreshev authored Oct 3, 2023
1 parent 1d514ea commit c58b6df
Show file tree
Hide file tree
Showing 1,415 changed files with 103,088 additions and 64 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -213,3 +213,7 @@ LoadTest.code-workspace
.idea/
.nyc_output/
_dotnetsdk/

# BuildConfigGen files
FilesOverriddenForConfigGoHereREADME.txt

18 changes: 18 additions & 0 deletions BuildConfigGen/EnsureUpdateModeVerifier.cs
Original file line number Diff line number Diff line change
Expand Up @@ -251,5 +251,23 @@ private string ResolveFile(string filePath)
string targetFile = tempFile ?? sourceFile ?? filePath;
return targetFile;
}

internal void DeleteDirectoryRecursive(string path)
{
if(verifyOnly)
{
if(Directory.Exists(path))
{
VerifyErrors.Add($"Expected directory {path} to not exist");
}
}
else
{
if(Directory.Exists(path))
{
Directory.Delete(path, true);
}
}
}
}
}
196 changes: 152 additions & 44 deletions BuildConfigGen/Program.cs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion BuildConfigGen/Properties/launchSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"profiles": {
"BuildConfigGen": {
"commandName": "Project",
"commandLineArgs": "--task AndroidSigningV2,AndroidSigningV3,DockerComposeV0,DownloadFileshareArtifactsV1,DownloadPackageV1,FuncToolsInstallerV0,GitHubCommentV0,KubernetesManifestV0,KubernetesV0,MysqlDeploymentOnMachineGroupV1,NuGetRestoreV1,PackerBuildV0,PackerBuildV1,PublishCodeCoverageResultsV1 --configs Node16_225 --write-updates"
"commandLineArgs": "--write-updates --configs \"Node20\" --task DecryptFileV1"
}
}
}
5 changes: 5 additions & 0 deletions BuildConfigGen/TaskVersion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ public TaskVersion Clone()
return new TaskVersion(this);
}

public TaskVersion CloneWithMinorAndPatch(int minor, int overridePatch)
{
return new TaskVersion(Major, minor, overridePatch);
}

public TaskVersion CloneWithPatch(int overridePatch)
{
return new TaskVersion(Major, Minor, overridePatch);
Expand Down
14 changes: 14 additions & 0 deletions Tasks/ANTV1/_buildConfigs/Node20/Tests/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions Tasks/ANTV1/_buildConfigs/Node20/Tests/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"name": "antv1-tests",
"version": "1.0.0",
"description": "Azure Pipelines Ant V1 Task Tests",
"main": "L0.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+ssh://[email protected]/Microsoft/azure-pipelines-tasks.git"
},
"author": "Microsoft Corporation",
"license": "MIT",
"bugs": {
"url": "https://github.com/Microsoft/azure-pipelines-tasks/issues"
},
"homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
"devDependencies": {
"@types/mocha": "^5.2.7"
}
}
Loading

0 comments on commit c58b6df

Please sign in to comment.