Fix check-downgrading promise error handling (#19069)

* Add catch to main function * Update condition count base on tasks for downgrading check
microsoft · Dec 7, 2023 · 99b6c67 · 99b6c67
1 parent 5bdfc46
commit 99b6c67
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/ci/build-all-steps.yml b/ci/build-all-steps.yml
@@ -74,7 +74,7 @@ steps:
   condition: |
       and(
         succeeded(),
-        ne(variables['numTasks'], 0),
+        ne(variables['numTasksForDowngradingCheck'], 0),
         ne(variables['COURTESY_PUSH'], 'true'),
         eq(variables['build.reason'], 'PullRequest'),
         eq(variables['System.PullRequest.TargetBranch'], 'master')

diff --git a/ci/check-downgrading.js b/ci/check-downgrading.js
@@ -260,4 +260,8 @@ async function main({ task, sprint, week }) {
   }
 }
 
-main(argv);
+main(argv)
+  .catch(error => {
+    console.error(error);
+    process.exit(1);
+  });
diff --git a/ci/filter-tasks.js b/ci/filter-tasks.js
@@ -216,6 +216,7 @@ var setTaskVariables = function(tasks, tasksForDowngradingCheck) {
     console.log('##vso[task.setVariable variable=task_pattern;isOutput=true;]@(' + tasks.join('|') + ')');
     console.log('##vso[task.setVariable variable=task_pattern_fordowngradingcheck]@(' + tasksForDowngradingCheck.join('|') + ')');
     console.log('##vso[task.setVariable variable=numTasks]' + tasks.length);
+    console.log('##vso[task.setVariable variable=numTasksForDowngradingCheck]' + tasksForDowngradingCheck.length);
 }
 
 var buildReason = process.env['BUILD_REASON'].toLowerCase();