Merge pull request #10539 from pfleidi/feature/app-center-distribute-…

…chunked-symbol-files

Feature/app center distribute chunked symbol files

Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson

@@ -1,7 +1,7 @@
 {
   "loc.friendlyName": "App Center distribute",
   "loc.helpMarkDown": "For help with this task, visit the Visual Studio App Center [support site](https://aka.ms/appcentersupport/).",
-  "loc.description": "Distribute app builds to testers and users via App Center",
+  "loc.description": "Distribute app builds to testers and users via Visual Studio App Center",
   "loc.instanceNameFormat": "Deploy $(app) to Visual Studio App Center",
   "loc.releaseNotes": "Fix bug where feature branches were being truncated.",
   "loc.group.displayName.symbols": "Symbols",

Tasks/AppCenterDistributeV1/Tests/L0.ts

@@ -85,7 +85,7 @@ describe('AppCenterDistribute L0 Suite', function () {
         assert(tr.succeeded, 'task should have succeeded');
     });
 
-    it('Positive path: multiple dSYMs in the same foder', function () {
+    it('Positive path: multiple dSYMs in the same folder', function () {
         this.timeout(4000);
 
         let tp = path.join(__dirname, 'L0SymMultipleDSYMs_flat_1.js');
@@ -95,7 +95,7 @@ describe('AppCenterDistribute L0 Suite', function () {
         assert(tr.succeeded, 'task should have succeeded');
     });
 
-    it('Positive path: multiple dSYMs in parallel foders', function () {
+    it('Positive path: multiple dSYMs in parallel folders', function () {
         this.timeout(4000);
 
         let tp = path.join(__dirname, 'L0SymMultipleDSYMs_flat_2.js');
@@ -186,7 +186,7 @@ describe('AppCenterDistribute L0 Suite', function () {
         assert(tr.succeeded, 'task should have succeeded');
     });
 
-    it('Positive path: publish mandatory update)', function () {
+    it('Positive path: publish mandatory update', function () {
         this.timeout(4000);
 
         let tp = path.join(__dirname, 'L0PublishMandatoryUpdate.js');

Tasks/AppCenterDistributeV1/Tests/L0OneIpaPass.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -63,13 +65,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -115,6 +110,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0PublishCommitInfo_1.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -76,13 +78,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -128,6 +123,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0PublishCommitInfo_2.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -74,13 +76,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -126,6 +121,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0PublishCommitInfo_3.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -74,13 +76,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -126,6 +121,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0PublishCommitInfo_4.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -74,13 +76,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -126,6 +121,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0PublishMandatoryUpdate.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Stats = require('fs').Stats
 
@@ -75,13 +77,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch("/v0.1/apps/testuser/testapp/symbol_uploads/100", {
@@ -127,6 +122,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0SymIncludeParent.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Writable = require('stream').Writable
 var Stats = require('fs').Stats
@@ -65,13 +67,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch('/v0.1/apps/testuser/testapp/symbol_uploads/100', {
@@ -166,6 +161,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0SymMultipleDSYMs_flat_1.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Writable = require('stream').Writable
 var Stats = require('fs').Stats
@@ -81,13 +83,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch('/v0.1/apps/testuser/testapp/symbol_uploads/100', {
@@ -202,6 +197,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0SymMultipleDSYMs_flat_2.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Writable = require('stream').Writable
 var Stats = require('fs').Stats
@@ -83,13 +85,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch('/v0.1/apps/testuser/testapp/symbol_uploads/100', {
@@ -212,6 +207,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();

Tasks/AppCenterDistributeV1/Tests/L0SymMultipleDSYMs_single.ts

@@ -3,6 +3,8 @@ import ma = require('vsts-task-lib/mock-answer');
 import tmrm = require('vsts-task-lib/mock-run');
 import path = require('path');
 import fs = require('fs');
+import azureBlobUploadHelper = require('../azure-blob-upload-helper');
+
 var Readable = require('stream').Readable
 var Writable = require('stream').Writable
 var Stats = require('fs').Stats
@@ -79,13 +81,6 @@ nock('https://example.test')
         expiration_date: 1234567
     });
 
-//upload symbols
-nock('https://example.upload.test')
-    .put('/symbol_upload')
-    .reply(201, {
-        status: 'success'
-    });
-
 //finishing symbol upload, commit the symbol 
 nock('https://example.test')
     .patch('/v0.1/apps/testuser/testapp/symbol_uploads/100', {
@@ -193,6 +188,12 @@ fs.statSync = (s: string) => {
 
     return stat;
 }
+
+azureBlobUploadHelper.AzureBlobUploadHelper.prototype.upload = async () => {
+    return Promise.resolve();
+}
+
+tmr.registerMock('azure-blob-upload-helper', azureBlobUploadHelper);
 tmr.registerMock('fs', fs);
 
 tmr.run();