Skip to content

Commit

Permalink
[ARG Deploy] Updating description and stringifying error logs (#7154)
Browse files Browse the repository at this point in the history
* Updating description and stringifying error logs

* Updating description

* Minor version bump up.
  • Loading branch information
thesattiraju authored May 10, 2018
1 parent 1dd7baa commit 600cc0c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"loc.friendlyName": "Azure Resource Group Deployment",
"loc.helpMarkDown": "[More Information](https://aka.ms/argtaskreadme)",
"loc.description": "Deploy, start, stop, delete Azure Resource Groups",
"loc.description": "Deploy an Azure resource manager (ARM) template to a resource group. You can also start, stop, delete, deallocate all Virtual Machines (VM) in a resource group",
"loc.instanceNameFormat": "Azure Deployment:$(action) action on $(resourceGroupName)",
"loc.releaseNotes": "-Works with cross-platform agents (Linux, macOS, or Windows)\n- Supports Template JSONs located at any publicly accessible http/https URLs.\n- Enhanced UX for Override parameters which can now be viewed/edited in a grid.\n- NAT rule mapping for VMs which are backed by an Load balancer.\n- \"Resource group\" field is now renamed as \"VM details for  WinRM\" and is included in the section \"Advanced deployment options for virtual machines\".\n- Limitations: \n - No support for Classic subscriptions. Only for ARM subscriptions are supported.\n - No support for PowerShell syntax as the task is now node.js based. Ensure the case sensitivity of the parameter names match, when you override the template parameters. Also, remove the PowerShell cmdlets like \"ConvertTo-SecureString\" when you migrate from version 1.0 to version 2.0.",
"loc.group.displayName.AzureDetails": "Azure Details",
Expand Down
7 changes: 4 additions & 3 deletions Tasks/AzureResourceGroupDeploymentV2/operations/Utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ class Utils {
return (!!str && !!str.trim());
}

public static getError(error: any) {
public static getError(error: any): string {
if (error && error.message) {
return error.message;
return JSON.stringify(error.message);
}
return error;

return JSON.stringify(error);
}
}

Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureResourceGroupDeploymentV2/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "94A74903-F93F-4075-884F-DC11F34058B4",
"name": "AzureResourceGroupDeployment",
"friendlyName": "Azure Resource Group Deployment",
"description": "Deploy, start, stop, delete Azure Resource Groups",
"description": "Deploy an Azure resource manager (ARM) template to a resource group. You can also start, stop, delete, deallocate all Virtual Machines (VM) in a resource group",
"helpMarkDown": "[More Information](https://aka.ms/argtaskreadme)",
"category": "Deploy",
"releaseNotes": "-Works with cross-platform agents (Linux, macOS, or Windows)\n- Supports Template JSONs located at any publicly accessible http/https URLs.\n- Enhanced UX for Override parameters which can now be viewed/edited in a grid.\n- NAT rule mapping for VMs which are backed by an Load balancer.\n- \"Resource group\" field is now renamed as \"VM details for  WinRM\" and is included in the section \"Advanced deployment options for virtual machines\".\n- Limitations: \n - No support for Classic subscriptions. Only for ARM subscriptions are supported.\n - No support for PowerShell syntax as the task is now node.js based. Ensure the case sensitivity of the parameter names match, when you override the template parameters. Also, remove the PowerShell cmdlets like \"ConvertTo-SecureString\" when you migrate from version 1.0 to version 2.0.",
Expand All @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 131,
"Patch": 3
"Minor": 134,
"Patch": 0
},
"demands": [],
"minimumAgentVersion": "2.119.1",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/AzureResourceGroupDeploymentV2/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 131,
"Patch": 3
"Minor": 134,
"Patch": 0
},
"demands": [],
"minimumAgentVersion": "2.119.1",
Expand Down

0 comments on commit 600cc0c

Please sign in to comment.