Adding fix for removing old trx files in case of multiple test tasks (#…

…6615) * Adding fix for removing old trx files in case of multiple test tasks * Fixing tests
microsoft · Mar 8, 2018 · 061c443 · 061c443
1 parent a035732
commit 061c443
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 2 deletions.
diff --git a/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtests.ts b/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtests.ts
@@ -41,6 +41,11 @@ const a: ma.TaskLibAnswers = <ma.TaskLibAnswers>{
     'findMatch': {
         'temp.csproj': ['c:\\agent\\home\\directory\\temp.csproj'],
         '**/*.trx': ['c:\\agent\\home\\temp\\sample.trx']
+    },
+    "rmRF": {
+        "c:\\agent\\home\\temp\\sample.trx": {
+            "success": true
+        }
     }
 };
 nmh.setAnswers(a);

diff --git a/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtestsWithFailedTestCommand.ts b/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtestsWithFailedTestCommand.ts
@@ -41,6 +41,11 @@ const a: ma.TaskLibAnswers = <ma.TaskLibAnswers>{
     'findMatch': {
         'temp.csproj': ['c:\\agent\\home\\directory\\temp.csproj'],
         '**/*.trx': ['c:\\agent\\home\\temp\\sample.trx']
+    },
+    "rmRF": {
+        "c:\\agent\\home\\temp\\sample.trx": {
+            "success": true
+        }
     }
 };
 nmh.setAnswers(a);

diff --git a/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtestsWithoutBuildConfig.ts b/Tasks/DotNetCoreCLI/Tests/TestCommandTests/publishtestsWithoutBuildConfig.ts
@@ -39,6 +39,11 @@ const a: ma.TaskLibAnswers = <ma.TaskLibAnswers>{
     'findMatch': {
         'temp.csproj': ['c:\\agent\\home\\directory\\temp.csproj'],
         '**/*.trx': ['c:\\agent\\home\\temp\\sample.trx']
+    },
+    "rmRF": {
+        "c:\\agent\\home\\temp\\sample.trx": {
+            "success": true
+        }
     }
 };
 nmh.setAnswers(a);

diff --git a/Tasks/DotNetCoreCLI/dotnetcore.ts b/Tasks/DotNetCoreCLI/dotnetcore.ts
@@ -103,6 +103,9 @@ export class dotNetExe {
         if (enablePublishTestResults && enablePublishTestResults === true) {
             this.arguments = this.arguments.concat(` --logger trx --results-directory ${resultsDirectory}`);
         }
+
+        // Remove old trx files
+        this.removeOldTestResultFiles(resultsDirectory);
 
         // Use empty string when no project file is specified to operate on the current directory
         const projectFiles = this.getProjectFiles();
@@ -148,6 +151,19 @@ export class dotNetExe {
         }
     }
 
+    private removeOldTestResultFiles(resultsDir:string): void {
+        const matchingTestResultsFiles: string[] = tl.findMatch(resultsDir, '**/*.trx');
+        if (!matchingTestResultsFiles || matchingTestResultsFiles.length === 0) {
+            tl.debug("No old result files found.");
+            return;
+        }
+        for (const fileIndex of Object.keys(matchingTestResultsFiles)) {
+            const resultFile = matchingTestResultsFiles[fileIndex];            
+            tl.rmRF(resultFile)
+            tl.debug("Successfuly removed: " + resultFile);
+        }
+    }
+
     private replaceOutputArgument(modifiedOutput: string) {
         var str = this.arguments;
         var index = this.outputArgumentIndex;

diff --git a/Tasks/DotNetCoreCLI/task.json b/Tasks/DotNetCoreCLI/task.json
@@ -16,7 +16,7 @@
     "demands": [],
     "version": {
         "Major": 2,
-        "Minor": 131,
+        "Minor": 132,
         "Patch": 0
     },
     "minimumAgentVersion": "2.0.0",

diff --git a/Tasks/DotNetCoreCLI/task.loc.json b/Tasks/DotNetCoreCLI/task.loc.json
@@ -16,7 +16,7 @@
   "demands": [],
   "version": {
     "Major": 2,
-    "Minor": 131,
+    "Minor": 132,
     "Patch": 0
   },
   "minimumAgentVersion": "2.0.0",