Transform webdeployment-common tests into real test suites #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetocny
changed the title
common-npm-packages/webdeployment-common/Tests/L0CopyDirectory.ts
Outdated
Show resolved
Hide resolved
DmitriiBobreshev
approved these changes
Oct 19, 2023
Applying Vlad's suggestion Co-authored-by: Vladyslav Horbachov <[email protected]>
2 tasks
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now tests from
webdeployment-commonwere not run during package build process. Instead of that pipeline tasks that are using this package were running JavaScript files fromwebdeployment-common\Testsfolder. Also there were missing real test suites (describe) with particular tests (it). This PR introduces newL0.tsfile that contains calls to all existing tests. All tests were wrapped into test suites and additional fixes were applied where it was necessary.