Update Sync-Request version in package.json #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #11136 on microsoft/azure-pipelines-tasks points out that sync-request is way more up-to-date than 3.0.1 - Is there any reason not to advance the version for this library? At a minimum changing it to `^3.0.1`, if not something higher? I personally am experiencing similar issues with this erroring out when being run on a pipeline agent even if my version of package.json has a higher version.
|
3.0.1 is the last version that is supported for Node 6, which most tasks currently rely on. There is work in-flight to bring tasks up to Node 14. I have bumped sync-request up to 6.1.0 as a part of this work here: #665 Also worth noting that 3.0.1 is the last version in the semver major |
This was referenced Sep 17, 2020
|
Fair enough! I'll close out this PR and watch out for yours. Thank you for taking a look @alex-peck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a similar PR on azure-pipelines-tasks but that may not be the exact right place. microsoft/azure-pipelines-tasks#13556
Issue #11136 on microsoft/azure-pipelines-tasks points out that sync-request is way more up-to-date than 3.0.1 - Is there any reason not to advance the version for this library? At a minimum changing it to
^3.0.1, if not something higher?I personally am experiencing similar issues with this erroring out when being run on a pipeline agent even if my version of package.json has a higher version.