Use name instead of ID as a ref for sec files. #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is strongly related to the following one: microsoft/azure-pipelines-tasks-common-packages#307 |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to fix the following issue: microsoft/azure-pipelines-tasks#6885
In the classic pipelines the secure file reference was stored by the GUID of the secure file which was generated upon upload. The flaw in this design was that the secure file has no option to update it's content.
When for example a config file has to be changed because of infrastructural changes then every classic pipeline using that secure file breaks because the newly uploaded secure file has a different GUID.
In the context of yaml pipelines this does not cause any issue because we store the secure file by name.