Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

username and passwordSecretRef settings remain after executing the az containerapp registry set --identity command #261

Closed
1 of 3 tasks
YuKogasaka opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
CLI Related to CLI

Comments

@YuKogasaka
Copy link

This issue is a: (mark with an x)

  • bug report -> please search issues before submitting
  • documentation issue or request
  • regression (a behavior that used to work and stopped in a new release)

Issue description

In Azue CLI containerapp extension v0.3.6, I ran to change the authentication to ACR to a Managed ID using az containerapp registry set --identity command, but the username and passwordSecretRef settings are still remain.

Steps to reproduct

  1. The following command was executed for existing ACA (deploy from ACR, authentication method is username/password).
az containerapp registry set \
  -n '<ACA Name>' \
  -g '<Resouce Group Name>' \
  --server '<ACR Server Name>' \
  --identity 'system'

Expected behavior [What you expected to happen.]
I think the execution result should be like this.

Updating existing registry.
[
  {
    "identity": "system",
    "server": "<ACR Server Name>",
  }
]

Actual behavior [What actually happened.]
Actually, the result is as follows.
Note : The result was the same for --identity '<user-assigned managed ID'

Updating existing registry.
[
  {
    "identity": "system",
    "passwordSecretRef": "<Password (Secret)>",
    "server": "<ACR Server Name>",
    "username": "<User Name>"
  }
]

Additional context

  • az version resuilts
{
  "azure-cli": "2.37.0",
  "azure-cli-core": "2.37.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "containerapp": "0.3.6",
    "ssh": "1.1.1"
  }
}
@ghost ghost added the Needs: triage 🔍 Pending a first pass to read, tag, and assign label Jun 9, 2022
StrawnSC added a commit to StrawnSC/azure-cli-extensions that referenced this issue Jun 9, 2022
@StrawnSC
Copy link

The fix for this will be released with the next version of the containerapp CLI extension

@anthonychu anthonychu added CLI Related to CLI and removed Needs: triage 🔍 Pending a first pass to read, tag, and assign labels Jun 13, 2022
@StrawnSC
Copy link

StrawnSC commented Jul 6, 2022

@anthonychu the fix for this has been released as well

runefa added a commit to calvinsID/azure-cli-extensions that referenced this issue Jul 15, 2022
* init containerapp version 0.3.7

* Use PATCH API for containerapp update.

* Removed double lines.

* fix bug

* Fix microsoft/azure-container-apps#261

* Fixed issue where containerapp up would not honor --registry-server. (#128)

* Fixed issue where containerapp up would not honor --registry-server.

* Updated history.

Co-authored-by: Haroon Feisal <[email protected]>

* bug fix

* add tests

* fix credscan suppressions

* Use constant for acr registry prefix.

* Fixed multi-container issue.

* Removed comment.

* Updated update_containerapp_yaml to use patch. Fixed minor style errors.

* Fixed merge conflicts.

* Rerecorded necessary tests.

* Updated history.

* Auto-populate secret values if passed without values.

* Fixed bug where the containerapp had no secrets.

Co-authored-by: Silas Strawn <[email protected]>
Co-authored-by: Haroon Feisal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Related to CLI
Projects
None yet
Development

No branches or pull requests

4 participants