chore: migrate to yarn v3 #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…medriver instructions
2 tasks
dbjorge
added a commit
to microsoft/accessibility-insights-web
that referenced
this pull request
Mar 22, 2023
#### Details Migrates the repo's package manager from yarn v1 to yarn v3 (in non-zero-installs configuration) Some of this was mechanical based on [Yarn's migration guide](https://yarnpkg.com/getting-started/migration). Beyond the steps there, this PR: * Updates assorted CI pipelines/workflows and dev docs to adapt to minor syntax updates * Updates CI workflow's caching strategy to use `actions/setup-node@v3`'s built-in support for yarn berry friendly caching instead of implementing our own with `actions/cache@v3` * Updates license-check-and-add and prettier configs to exclude `.yarn/` * Updates e2e `Dockerfile` to account for new changes * Drops Lerna dependency in favor of plain Yarn workspaces, similar to service and action ##### Motivation * Simplifies some common dev commands. In particular, the command to update report package snapshots changes from `yarn test:report:e2e -- -- -- -u` to just `yarn test:report:e2e -u` * Consistency with other repos * Allows for versioned resolutions (similar to microsoft/accessibility-insights-action#1596) - I left modifying existing resolutions out of scope since this PR was already pretty large without them, will cover them in a different PR * Removes a dependency (Lerna) ##### Context Similar PRs in other repos: * microsoft/accessibility-insights-service#2210 * microsoft/accessibility-insights-action#1559 * microsoft/accessibility-insights-action#1596 * microsoft/axe-sarif-converter#935 * https://github.com/microsoft/accessibility-insights-docs/pull/1577 #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [n/a] Added/updated relevant unit test(s) (and ran `yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR migrates the repo from Yarn v1 to Yarn v3 for dependency management. The main migration followed the steps in Yarn's migration guide for a non-zero-installs configuration, similar to the migrations in accessibility-insights-service and accessibility-insights-action.
Besides the required/mechanical steps, this PR also includes:
test-resourcesgenerator setup to work as a run script from the root directory instead of using a separatepackage.jsoninsrc/test-resources/generator. This avoided what would have otherwise required a more complicated setup using either multiple checked in copies of yarn or a more complicated workspace setup, and slightly simplifies the steps for using the generator. I updated the README instructions accordingly.!dist/test-resourcesentry in thefilesfield ofpackage.jsonensures that there is no change to the package as-distributed because of this update.As part of these changes, I verified manually that
yarn generate-test-resourcesregenerates the current versions of the test resource files successfully.Motivation
Context
Similar PRs in other repos:
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckin