Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add version mapping info to readme #63

Merged
merged 4 commits into from
Jun 21, 2019

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 21, 2019

Description of changes

Adds a "Version numbers" section to the README that describes the mappings between axe-sarif-converter version and axe-core/SARIF format versions.

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • (if applicable) Addresses issue: #0000
  • Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@dbjorge dbjorge requested a review from a team June 21, 2019 01:07
@dbjorge dbjorge added the pr: DO NOT MERGE Dont merge this PR. label Jun 21, 2019
@dbjorge
Copy link
Contributor Author

dbjorge commented Jun 21, 2019

Marking DO NOT MERGE until we actually cut the v2 release

@dbjorge
Copy link
Contributor Author

dbjorge commented Jun 21, 2019

Going to merge this change in now so it's in as part of the initial v2 release

@dbjorge dbjorge closed this Jun 21, 2019
@dbjorge dbjorge reopened this Jun 21, 2019
@dbjorge dbjorge removed the pr: DO NOT MERGE Dont merge this PR. label Jun 21, 2019
@dbjorge dbjorge merged commit 9dd4633 into microsoft:master Jun 21, 2019
@dbjorge dbjorge deleted the add-version-info-to-readme branch June 21, 2019 20:00
@ada-cat
Copy link
Collaborator

ada-cat commented Jun 22, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants