feat(axe-core-4.9.1): update to use axe-core 4.9.1 #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Per the instructions in CONTRIBUTING.md, I think we also need to update the devDependencies in package.json for @axe-core/cli and @axe-core/puppeteer. And then regenerate the resources. Additionally, src/cli.test.ts needs to be updated similar to how src/index.test.ts was updated.
|
@madalynrose i updated version for @axe-core/cli and @axe-core/puppeteer. |
v-viyada
changed the title
madalynrose
requested changes
Jun 19, 2024
Co-authored-by: Madalyn <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
madalynrose
approved these changes
Jun 20, 2024
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR upgrades axe-core to 4.9.1 according to the instructions in CONTRIBUTING.md.
Motivation
feature work 🚀
Context
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE::for examplefeat(feature): feature titleotherwise it will not be considered by semantic-release for release.yarn precheckin