Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix groupchat #904

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Minor fix groupchat #904

merged 7 commits into from
Jan 3, 2024

Conversation

yiranwu0
Copy link
Collaborator

@yiranwu0 yiranwu0 commented Dec 7, 2023

Why are these changes needed?

Related issue number

Mentioned in #781

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d20bc09) 30.74% compared to head (19448f4) 40.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   30.74%   40.49%   +9.74%     
==========================================
  Files          30       30              
  Lines        4033     4033              
  Branches      913      962      +49     
==========================================
+ Hits         1240     1633     +393     
+ Misses       2714     2289     -425     
- Partials       79      111      +32     
Flag Coverage Δ
unittests 40.41% <ø> (+9.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney
Copy link
Member

afourney commented Dec 7, 2023

Looks good, but some debug print statements are left in.

@davorrunje
Copy link
Collaborator

LGTM 👍

@sonichi sonichi added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 8a26d3b Jan 3, 2024
76 of 84 checks passed
@sonichi sonichi deleted the fixvar branch January 3, 2024 01:38
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Update Research.md

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/Research.md

Co-authored-by: Chi Wang <[email protected]>

---------

Co-authored-by: Chi Wang <[email protected]>
Co-authored-by: Qingyun Wu <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* minor fix groupchat

* update

* update

---------

Co-authored-by: Davor Runje <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants