Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry setup #824

Merged
merged 6 commits into from
Dec 26, 2023
Merged

Add poetry setup #824

merged 6 commits into from
Dec 26, 2023

Conversation

rlam3
Copy link
Collaborator

@rlam3 rlam3 commented Nov 30, 2023

Missing poetry setup

Updated docs

Checks

@sonichi sonichi requested review from thinkall, pcdeadeasy and a team December 3, 2023 06:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebd5de9) 30.21% compared to head (a0ec4ab) 30.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   30.21%   30.21%           
=======================================
  Files          30       30           
  Lines        3988     3988           
  Branches      899      899           
=======================================
  Hits         1205     1205           
  Misses       2704     2704           
  Partials       79       79           
Flag Coverage Δ
unittests 30.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor

sonichi commented Dec 3, 2023

The contribution license agreement needs to be agreed before this contribution can be taken.

@rlam3
Copy link
Collaborator Author

rlam3 commented Dec 19, 2023

@microsoft-github-policy-service agree

@rlam3
Copy link
Collaborator Author

rlam3 commented Dec 19, 2023

@sonichi ready whenever you are to merge this 👍

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rlam3 . I've tried following the commands you shared. It was a little bit confusing to me at the beginning, but I get it now.

Would you like to explain a little bit more about poetry in the doc to help beginners to try with poetry?

@rlam3
Copy link
Collaborator Author

rlam3 commented Dec 21, 2023

Thanks @rlam3 . I've tried following the commands you shared. It was a little bit confusing to me at the beginning, but I get it now.

Would you like to explain a little bit more about poetry in the doc to help beginners to try with poetry?

How about now?

website/docs/Installation.md Outdated Show resolved Hide resolved
website/docs/Installation.md Show resolved Hide resolved
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the code format issue? You can use pre-commit to do the work.

@rlam3
Copy link
Collaborator Author

rlam3 commented Dec 25, 2023

Could you fix the code format issue? You can use pre-commit to do the work.

fixed.

@ekzhu ekzhu enabled auto-merge December 25, 2023 20:05
@ekzhu ekzhu requested a review from thinkall December 25, 2023 21:48
@ekzhu ekzhu added this pull request to the merge queue Dec 26, 2023
Merged via the queue into microsoft:main with commit 5b420f1 Dec 26, 2023
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Qingyun Wu <[email protected]>
Co-authored-by: Kevin Chen <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add poetry setup

* Add description of poetry linking to it's docs

* Update website/docs/Installation.md

Co-authored-by: Li Jiang <[email protected]>

* fix with pre-commit

---------

Co-authored-by: Li Jiang <[email protected]>
Co-authored-by: Eric Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants