Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore TeachableAgent tests #761

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Restore TeachableAgent tests #761

merged 9 commits into from
Nov 27, 2023

Conversation

rickyloynd-microsoft
Copy link
Contributor

Why are these changes needed?

  • The pytest testing of TeachableAgent was disabled in the recent API update. This PR restores the tests, now located in the test/contrib folder.
  • A new test is added to verify that the accuracy of teachability does not drop significantly.

Related issue number

Closes #450

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8d0527) 27.81% compared to head (67d792e) 48.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #761       +/-   ##
===========================================
+ Coverage   27.81%   48.85%   +21.03%     
===========================================
  Files          27       27               
  Lines        3480     3480               
  Branches      789      831       +42     
===========================================
+ Hits          968     1700      +732     
+ Misses       2441     1603      -838     
- Partials       71      177      +106     
Flag Coverage Δ
unittests 48.59% <ø> (+20.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/contrib-openai.yml Outdated Show resolved Hide resolved
.github/workflows/contrib-tests.yml Outdated Show resolved Hide resolved
test/agentchat/contrib/test_teachable_agent.py Outdated Show resolved Hide resolved
website/docs/Installation.md Show resolved Hide resolved
@sonichi sonichi added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 0468f53 Nov 27, 2023
67 of 70 checks passed
@sonichi sonichi deleted the test-teach branch December 3, 2023 22:55
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Update chat_with_teachable_agent.py to v2.

* Update agentchat_teachability.ipynb to v2.

* Add test of teachability accuracy.

* Update installation instructions.

* Add to contrib tests.

* pre-commit fixes

* Apply reviewer suggestions to test workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add back the test for teachable agent
5 participants