-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix assistant creating without file #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Adding a test will be nice, though not mandatory for this PR.
Btw there is an issue for adding a notebook example as well (tho not a substitute for the test) #641 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
===========================================
+ Coverage 28.85% 48.30% +19.45%
===========================================
Files 27 27
Lines 3393 3393
Branches 764 806 +42
===========================================
+ Hits 979 1639 +660
+ Misses 2342 1577 -765
- Partials 72 177 +105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi PTAL again, a simple assistant file checking unit test is added |
* fix assistant creating without file * add a simple unit test * format code
Why are these changes needed?
Creating an assistant with file ids, otherwise the retrieval function cannot be used.
Related issue number
Checks