Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assistant creating without file #689

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

IANTHEREAL
Copy link
Collaborator

@IANTHEREAL IANTHEREAL commented Nov 15, 2023

Why are these changes needed?

Creating an assistant with file ids, otherwise the retrieval function cannot be used.

Related issue number

Checks

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Adding a test will be nice, though not mandatory for this PR.

@gagb
Copy link
Collaborator

gagb commented Nov 15, 2023

Btw there is an issue for adding a notebook example as well (tho not a substitute for the test) #641

@gagb gagb mentioned this pull request Nov 15, 2023
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0a6d72) 28.85% compared to head (ffbdd47) 48.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #689       +/-   ##
===========================================
+ Coverage   28.85%   48.30%   +19.45%     
===========================================
  Files          27       27               
  Lines        3393     3393               
  Branches      764      806       +42     
===========================================
+ Hits          979     1639      +660     
+ Misses       2342     1577      -765     
- Partials       72      177      +105     
Flag Coverage Δ
unittests 48.12% <ø> (+19.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IANTHEREAL
Copy link
Collaborator Author

@sonichi PTAL again, a simple assistant file checking unit test is added

@sonichi sonichi added this pull request to the merge queue Nov 16, 2023
Merged via the queue into microsoft:main with commit a730a63 Nov 16, 2023
55 of 58 checks passed
@IANTHEREAL IANTHEREAL deleted the oai-assistant-bug branch November 16, 2023 13:52
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix assistant creating without file

* add a simple unit test

* format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants