Refactor code executor namespace #4538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspinheiro
commented
Dec 4, 2024
| from ._azure_container_code_executor import ACADynamicSessionsCodeExecutor, TokenProvider | ||
| from ._docker_code_executor import DockerCommandLineCodeExecutor | ||
| from .azure import ACADynamicSessionsCodeExecutor, TokenProvider | ||
| from .docker import DockerCommandLineCodeExecutor | ||
|
|
||
| __all__ = ["DockerCommandLineCodeExecutor", "TokenProvider", "ACADynamicSessionsCodeExecutor"] |
There was a problem hiding this comment.
Do you want to keep this or force imports from the respective extra namespaces?
There was a problem hiding this comment.
To prevent problems with optional dependencies I think we need to force the import from the nested module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To improve extra module dependency management. This PR only addresses the
code_executorsnamespace and will be followed up by PRs for the other component namespaces.Related issue number
Part of ##4408
Checks