fix: remove subscription on client disconnect in worker runtime #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhu
reviewed
Oct 4, 2024
ekzhu
reviewed
Oct 4, 2024
python/packages/autogen-core/src/autogen_core/application/_helpers.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Oct 4, 2024
python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Oct 4, 2024
python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host_servicer.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Oct 4, 2024
MohMaz
commented
Oct 4, 2024
python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host_servicer.py
Show resolved
Hide resolved
|
cc: @jackgerrits in case you want to take a look following the conversation with had today |
ekzhu
reviewed
Oct 5, 2024
python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host_servicer.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Oct 5, 2024
python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host_servicer.py
Outdated
Show resolved
Hide resolved
ekzhu
approved these changes
Oct 5, 2024
rysweet
added a commit
that referenced
this pull request
Oct 8, 2024
* add logging to agentchat * Update magentic-one readme with the latest numbers (a complete set of results on WebArena, and updated results for GAIA) * make logging independent module * move logging module to root of agent_chat * Add staging to workflow target; fix circular imports in autogen_agentchat (#3651) * Fix formatting and remove duplicated import of EVENT_LOGGER_NAME in agentchat * add staging to target in checks * add staging to target in checks for dotnet * Fix circular imports * Add all redirect links (#3659) * generate docs on push, deploy on main * Remove accidentally added files from 0.2 (#3661) * try fix docs CI (#3660) Co-authored-by: Eric Zhu <[email protected]> * fix: remove subscription on client disconnect in worker runtime (#3653) * remove subscription on client disconnect in worker runtime * address PR feedback * remove outdated comment * remove public properties * fix mypy issue * address PR feedback --------- Co-authored-by: Jack Gerrits <[email protected]> * Move tools to agent in `agentchat`; refactored logging to support tool events (#3665) * Move tool to agent; refactor logging in agentchat * Update notebook * [.Net] Remove merging primitive from .editorconfig and gitignore (#3676) * remove merging primitive from .editorconfig and gitignore * use file scope namespace * remove file-scope name * fix format * Add poethepoet to dev deps (#3675) Co-authored-by: Eric Zhu <[email protected]> --------- Co-authored-by: Victor Dibia <[email protected]> Co-authored-by: Adam Fourney <[email protected]> Co-authored-by: gagb <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Mohammad Mazraeh <[email protected]> Co-authored-by: Xiaoyun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Potential conflict on subscriptions when agents disconnect on worker runtime.
See explanations in #3628
Related issue number
Closes #3628
Checks