Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedding function assignment in QdrantVectorDB #3396

Conversation

eddyfidel
Copy link
Contributor

Why are these changes needed?

These changes are needed to ensure that the QdrantVectorDB class behaves correctly when a custom embedding_function is provided. Previously, even if a custom function was passed, the code always defaulted to FastEmbedEmbeddingFunction(), which could lead to unexpected behavior and limit the flexibility of the class. By fixing this, we ensure that the custom embedding function is properly utilized, and only default to FastEmbedEmbeddingFunction() when no custom function is specified. This enhances the reliability and correctness of the embedding process within the class.

Related issue number

Checks

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for the PR, @efidel .

@thinkall thinkall added this pull request to the merge queue Aug 22, 2024
Merged via the queue into microsoft:main with commit 8aea367 Aug 22, 2024
131 of 143 checks passed
open-autogen pushed a commit to autogenhub/autogen that referenced this pull request Aug 22, 2024
…faulting to FastEmbedEmbeddingFunction() otherwise (microsoft#3396)

Co-authored-by: Li Jiang <[email protected]>
victordibia pushed a commit that referenced this pull request Aug 28, 2024
…faulting to FastEmbedEmbeddingFunction() otherwise (#3396)

Co-authored-by: Li Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants