-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Anthropic client class so system messages aren't lost #3392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks clean. thanks @marklysze
Hi @thinkall, I don't believe the OpenAI tests are required for this PR and I believe they are throwing the error:
I'm not clear on how to bypass them for the checks. The exception is related to a missing |
At the moment if the set of messages for inference has more than one system message, only the last system message will be put into the Anthropic API
system
parameter.During some testing of group chats I noticed there are multiple system messages for speaker selection in auto mode. So this meant the speaker selection was losing context and failing.
This PR simply concatenates the system messages together and it proves effective.
Why are these changes needed?
Group Chat doesn't work effectively with Anthropic models when in auto mode without it.
Related issue number
None raised.
Checks