Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing backticks breaking documentation in groupchat.last_speaker #3357

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

HenryKobin
Copy link
Contributor

Why are these changes needed?

There are missing backticks in docstring causing the generated reference documentation formatting to break.

Related issue number

N/A

Checks

@marklysze marklysze added the group chat/teams group-chat-related issues label Aug 16, 2024
@marklysze
Copy link
Collaborator

Changes look good, thanks @HenryKobin!

Before:
image

After:
image

@marklysze marklysze self-requested a review August 16, 2024 03:37
Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :), @qingyun-wu / @sonichi if you can assist with merge :)

@marklysze marklysze added the documentation Improvements or additions to documentation label Aug 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.44%. Comparing base (6279247) to head (d26e59f).
Report is 85 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3357       +/-   ##
===========================================
- Coverage   32.90%   20.44%   -12.46%     
===========================================
  Files          94       95        +1     
  Lines       10235    10661      +426     
  Branches     2193     2278       +85     
===========================================
- Hits         3368     2180     -1188     
- Misses       6580     8326     +1746     
+ Partials      287      155      -132     
Flag Coverage Δ
unittests 20.43% <ø> (-12.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marklysze marklysze added this pull request to the merge queue Aug 16, 2024
Merged via the queue into microsoft:main with commit 3fc708d Aug 16, 2024
131 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants