-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing backticks breaking documentation in groupchat.last_speaker #3357
Conversation
Changes look good, thanks @HenryKobin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go :), @qingyun-wu / @sonichi if you can assist with merge :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3357 +/- ##
===========================================
- Coverage 32.90% 20.44% -12.46%
===========================================
Files 94 95 +1
Lines 10235 10661 +426
Branches 2193 2278 +85
===========================================
- Hits 3368 2180 -1188
- Misses 6580 8326 +1746
+ Partials 287 155 -132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are these changes needed?
There are missing backticks in docstring causing the generated reference documentation formatting to break.
Related issue number
N/A
Checks