Correcting tool calling with Cohere #3271
Conversation
Key in the directory should be 'message' and not 'content' as it checks for message empty at a later point in code.
Added required comments to the changes made in previous commit.
|
Hey @jaygdesai, thanks so much for finding this bug. Would you be able to list some code that caused the crash? I'll test the PR, thanks! |
marklysze
added
the
models
Added code that produces crash as a comment in bug issue here |
Hey @jaygdesai, perfect - thanks for sharing that. I've tested it and, yep, it fixes the bug. thank you! @qingyun-wu, this is good to go :) |
|
@marklysze I clicked on 'Update Repository' (wasn't sure if it was not supposed to be clicked as this is my first contribution). Please check if it needs approval again for merge - as it is showing that Workflow is awaiting approval. Thanks. |
|
Thanks @jaygdesai, running checks now, no problem... |
|
which version of pyautogen has fix this bug? |
Hi @Alaya-Con, this bug will be in the current release. The next release will have this corrected. |
* Update cohere.py Key in the directory should be 'message' and not 'content' as it checks for message empty at a later point in code. * Update cohere.py Added required comments to the changes made in previous commit.
Key in the directory should be 'message' and not 'content' as it checks for message empty at a later point in code.
Why are these changes needed?
When using Cohere API, internally in the file cohere.py, there is a mapping from openai tool calling format to cohere tool calling format. While using Cohere to perform tool calling, I encounted an error which ultimately resulted in the error message as under:
BadRequestError: status_code: 400, body: {'message': 'invalid request: all elements in history must have a message.'}Upon deeper investigation and back-tracing the error step-by-step, it was found that text of a key in a directory is checked to be 'message' instead of 'content' which is present in the code. As this condition is checked in the code, it results in an error as described above. Hence, changing it to 'message'.
Related issue number
#3270
Checks