Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the behavior for use_docker in execute_code #199 #204

Closed

Conversation

SDcodehub
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #204 (754a810) into main (d481aeb) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   43.71%   43.64%   -0.07%     
==========================================
  Files          17       17              
  Lines        2107     2110       +3     
  Branches      471      473       +2     
==========================================
  Hits          921      921              
- Misses       1104     1105       +1     
- Partials       82       84       +2     
Flag Coverage Δ
unittests 43.55% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
autogen/code_utils.py 48.92% <50.00%> (-0.64%) ⬇️

@thinkall
Copy link
Collaborator

Is the issue solved in #200?

@qingyun-wu
Copy link
Contributor

Yes, it is solved in #200! Closing this PR. Thanks for the contribution!

@qingyun-wu qingyun-wu closed this Oct 12, 2023
jackgerrits pushed a commit that referenced this pull request Oct 2, 2024
* Move file surfer to use baseagent

* Remove unused code

* Fix hatch err

* Intermediate commit to move mdconvert

* Fix linting errors

* Implement file surfer from autogen

* Run hatch check

* Fix more linting errors

* Fix errors in requests_markdown_browser. Ignore errors in mdconvert.

---------

Co-authored-by: Adam Fourney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants