-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 1440 by applying new function registration decorator #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
===========================================
+ Coverage 39.62% 50.93% +11.30%
===========================================
Files 57 57
Lines 6006 6006
Branches 1338 1456 +118
===========================================
+ Hits 2380 3059 +679
+ Misses 3433 2702 -731
- Partials 193 245 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thinkall
requested review from
gagb,
davorrunje,
AyushExel,
AaronWard,
ilaffey2,
Anush008 and
jidodata-ykim
February 13, 2024 06:14
This was referenced Feb 13, 2024
Open
davorrunje
reviewed
Feb 13, 2024
sonichi
added
rag
retrieve-augmented generative agents
tool-usage
suggestion and execution of function/tool call
labels
Feb 18, 2024
sonichi
approved these changes
Feb 18, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…soft#1661) * Reproduce microsoft#1440 * Updated code with latest APIs * Reran notebook * Fix usage of cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix #1440 by applying new function registration decorator.
@xianzhisheng , @LUK3ARK could you help verify if this PR fixes your user cases? Thanks.
Also fixed some usage of cache in notebooks and tests.
Related issue number
Closes #1440
Checks