Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1440 by applying new function registration decorator #1661

Merged
merged 10 commits into from
Feb 18, 2024
Merged

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Feb 13, 2024

Why are these changes needed?

Fix #1440 by applying new function registration decorator.

@xianzhisheng , @LUK3ARK could you help verify if this PR fixes your user cases? Thanks.

Also fixed some usage of cache in notebooks and tests.

Related issue number

Closes #1440

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ceee5d) 39.62% compared to head (2b9a930) 50.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1661       +/-   ##
===========================================
+ Coverage   39.62%   50.93%   +11.30%     
===========================================
  Files          57       57               
  Lines        6006     6006               
  Branches     1338     1456      +118     
===========================================
+ Hits         2380     3059      +679     
+ Misses       3433     2702      -731     
- Partials      193      245       +52     
Flag Coverage Δ
unittests 50.84% <ø> (+11.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 18, 2024
@sonichi sonichi removed this pull request from the merge queue due to a manual request Feb 18, 2024
@sonichi sonichi added this pull request to the merge queue Feb 18, 2024
Merged via the queue into main with commit 5aee911 Feb 18, 2024
49 of 60 checks passed
@sonichi sonichi deleted the fix_1440 branch February 18, 2024 16:06
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…soft#1661)

* Reproduce microsoft#1440

* Updated code with latest APIs

* Reran notebook

* Fix usage of cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rag retrieve-augmented generative agents tool-usage suggestion and execution of function/tool call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Function calling in groupchat does not work
4 participants