Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def _prepare_chat for groupchat manager to reset the groupchat #1254

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

yenif
Copy link
Collaborator

@yenif yenif commented Jan 15, 2024

Why are these changes needed?

Dirty messages from a previous chat can cause Tool Calls to raise an exception from the OpenAI API.

Related issue number

Screenshot 2024-01-16 at 9 29 25 PM
https://github.com/microsoft/autogen/actions/runs/7523612676/job/20477791898?pr=1226

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (260e0cf) 31.98% compared to head (3947fc8) 51.42%.

Files Patch % Lines
autogen/agentchat/groupchat.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1254       +/-   ##
===========================================
+ Coverage   31.98%   51.42%   +19.44%     
===========================================
  Files          33       33               
  Lines        4415     4422        +7     
  Branches     1030     1089       +59     
===========================================
+ Hits         1412     2274      +862     
+ Misses       2887     1944      -943     
- Partials      116      204       +88     
Flag Coverage Δ
unittests 51.35% <90.90%> (+19.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor

sonichi commented Jan 18, 2024

@joshkyh the merging is blocked by your change request.

@sonichi sonichi added this pull request to the merge queue Jan 18, 2024
@joshkyh
Copy link
Collaborator

joshkyh commented Jan 18, 2024

@joshkyh the merging is blocked by your change request.

Apologies, approved.

Merged via the queue into microsoft:main with commit 73c7522 Jan 18, 2024
79 of 84 checks passed
@sonichi sonichi deleted the groupchat_prepare_chat branch January 18, 2024 03:42
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…soft#1254)

* def _prepare_chat for groupchat manager to reset the groupchat

* typo

Co-authored-by: Chi Wang <[email protected]>

* typehint and simplify

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants