-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Compatibility with function call style API (Azure OpenAI and Gemini) #1227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 31.43% 41.31% +9.88%
==========================================
Files 32 32
Lines 4381 4393 +12
Branches 1022 1081 +59
==========================================
+ Hits 1377 1815 +438
+ Misses 2896 2437 -459
- Partials 108 141 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can anyone test this with Azure OpenAI would be great! I patched this based only on their JSON schema. |
Could you make one "openai" test that uses azure openai endpoints (use filter_dict on api_type)? |
# NOTE: for Azure OpenAI, please use API version 2023-12-01-preview or later as | ||
# support for earlier versions will be deprecated. | ||
# For API versions 2023-10-01-preview or earlier you may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 2023-10-01-preview exists as listed in the API spec repo. https://github.com/Azure/azure-rest-api-specs/tree/main/specification/cognitiveservices/data-plane/AzureOpenAI/inference/preview
…emini) (microsoft#1227) * microsoft#1206 * doc * add test for azure openai * prior to * filter for versions * up to * literal type * update doc
Why are these changes needed?
Add an optional argument to
register_for_llm
to support functional call style APIs (Azure OpenAI up to 2023-10-01-preview)e.g.
Related issue number
#1206
#1150
#1198
Checks