-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaner definition of tool_responses fixes #1174 #1182
cleaner definition of tool_responses fixes #1174 #1182
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
===========================================
+ Coverage 30.41% 48.79% +18.37%
===========================================
Files 32 32
Lines 4301 4300 -1
Branches 993 1044 +51
===========================================
+ Hits 1308 2098 +790
+ Misses 2899 1998 -901
- Partials 94 204 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I created PR #1184 today supporting streamed tool calls and I think I understand the new OpenAI API quite well now. I'll check this out carefully tomorrow, I am a bit too tired now. |
Why are these changes needed?
I couldn't replicate #1174, but I could imagine how this could have created an empty tool_responses.
I could also do a defensive dict key filter on generate_oai_reply, but feels really dirty. ideally there would be built out types and then it would work to just take the keys from the dict that are needed for the type. But that is a bigger thing.
Related issue number
Closes #1174
Checks