Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website accessibility #1153

Merged
merged 14 commits into from
Jan 18, 2024
Merged

Fix website accessibility #1153

merged 14 commits into from
Jan 18, 2024

Conversation

cheng-tan
Copy link
Contributor

@cheng-tan cheng-tan commented Jan 5, 2024

Why are these changes needed?

Fix accessibility issue for the website

TODO:

  • fix light theme accessibility issue
  • fix dark them accessibility issue

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (260e0cf) 31.98% compared to head (ac058be) 31.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   31.98%   31.98%           
=======================================
  Files          33       33           
  Lines        4415     4415           
  Branches     1030     1030           
=======================================
  Hits         1412     1412           
  Misses       2887     2887           
  Partials      116      116           
Flag Coverage Δ
unittests 31.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia self-requested a review January 5, 2024 22:39
@cheng-tan cheng-tan changed the title WIP: fix website accessibility Fix website accessibility Jan 9, 2024
@cheng-tan cheng-tan marked this pull request as ready for review January 9, 2024 00:34
@skzhang1
Copy link
Collaborator

The default appearance should not be dark. Can you change it to light? Thanks! @cheng-tan

@cheng-tan
Copy link
Contributor Author

cheng-tan commented Jan 17, 2024

The default appearance should not be dark. Can you change it to light? Thanks! @cheng-tan

Hi @skzhang1, is your system set to dark theme? I didn't change the default color mode, so it should still be light

@sonichi sonichi requested a review from a team January 17, 2024 18:54
Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the color contrast fixes @cheng-tan!
I was able to run without any errors.
Looking good!

@skzhang1
Copy link
Collaborator

The default appearance should not be dark. Can you change it to light? Thanks! @cheng-tan

Hi @skzhang1, is your system set to dark theme? I didn't change the default color mode, so it should still be light

Today I learned. My system is dark theme.

@sonichi sonichi added this pull request to the merge queue Jan 18, 2024
Merged via the queue into microsoft:main with commit 0f59322 Jan 18, 2024
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix light theme accessibility

* fix dark theme

* fix format

* Fix formatting

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants