-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix website accessibility #1153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
=======================================
Coverage 31.98% 31.98%
=======================================
Files 33 33
Lines 4415 4415
Branches 1030 1030
=======================================
Hits 1412 1412
Misses 2887 2887
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The default appearance should not be dark. Can you change it to light? Thanks! @cheng-tan |
Hi @skzhang1, is your system set to dark theme? I didn't change the default color mode, so it should still be light |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the color contrast fixes @cheng-tan!
I was able to run without any errors.
Looking good!
Today I learned. My system is dark theme. |
* fix light theme accessibility * fix dark theme * fix format * Fix formatting --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Fix accessibility issue for the website
TODO:
Related issue number
Checks