-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change contrib-tests.yml
tests to use --skip-openai
#1132
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
+ Coverage 31.80% 35.87% +4.06%
==========================================
Files 29 31 +2
Lines 4112 4298 +186
Branches 961 1042 +81
==========================================
+ Hits 1308 1542 +234
+ Misses 2710 2650 -60
- Partials 94 106 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but may conflict with #1072 since several tests needed to be corrected in that PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small issue.
@sonichi, I've modified both files, please check |
* Fixing RetrieveChat part * All 5 test groups are updated to --skip-openai * sys.path.append() fix
Why are these changes needed?
contrib-tests.yml
workflow usedpip uninstall -y openai
trick to skip the tests depending on OpenAI. Changed it to use pytest argument--skip-openai
insteadRelated issue number
Closes #1112
Notes
As of now the tests in
contrib-tests.yml
are mostly skipped cause they depend on OpenAI (~70-80% of individual tests are skipped). It makes sense to tidy up the file and remove all those OpenAI dependent tests as they don't do anything. Here're the breakdown for individual files:Checks