Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQs and guidelines on correctly setting up termination conditions in groupchat #525

Closed
gagb opened this issue Nov 2, 2023 · 7 comments
Labels
documentation Improvements or additions to documentation group chat/teams group-chat-related issues

Comments

@gagb
Copy link
Collaborator

gagb commented Nov 2, 2023

It seems that there are many way to setup termination in a group chat. But there is no single document detailing them. Is this correct @LittleLittleCloud? Maybe we can work together to add FAQs on it?

@LittleLittleCloud
Copy link
Collaborator

Sure, maybe adding a notebook on groupchat termination?

@sonichi sonichi added documentation Improvements or additions to documentation group chat/teams group-chat-related issues labels Nov 2, 2023
@gagb
Copy link
Collaborator Author

gagb commented Nov 2, 2023

Sure, maybe adding a notebook on groupchat termination?

Yes, I will make a PR. Thanks!

@afourney
Copy link
Member

afourney commented Nov 2, 2023

Notebooks are great, but it's fundamental enough that I'd love to see it somehow in the SDK documentation itself. Notebooks are great for examples, but when I'm coding with autogen, I've always got the Docs page (e.g., https://microsoft.github.io/autogen/docs/reference/agentchat/groupchat) open in the other browser tab.

@gagb
Copy link
Collaborator Author

gagb commented Nov 3, 2023

That sounds good, let me submit a notebook and then we can improve the documentation?

@gagb gagb mentioned this issue Nov 3, 2023
3 tasks
@gagb
Copy link
Collaborator Author

gagb commented Nov 3, 2023

Relevant comment for why function calls can help with termination:

https://github.com/microsoft/autogen/pull/309/files#r1382225372

@gagb
Copy link
Collaborator Author

gagb commented Mar 8, 2024

@ekzhu @jackgerrits -- we can accommodate this in the tutorial and then close it.

@thinkall
Copy link
Collaborator

We are closing this issue due to inactivity; please reopen if the problem persists.

jackgerrits pushed a commit that referenced this issue Oct 2, 2024
* starting #520 - readme improvements

* more for #520

* tiny announcement

* cleanupheader

* simplifying

* move announcement to top

* rearrange logo

* we dont need the logo

* bumping the date

* added faq addressing #500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation group chat/teams group-chat-related issues
Projects
None yet
Development

No branches or pull requests

5 participants