Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of use_cache in llm_config #323

Closed
rickyloynd-microsoft opened this issue Oct 20, 2023 · 4 comments
Closed

Documentation of use_cache in llm_config #323

rickyloynd-microsoft opened this issue Oct 20, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@rickyloynd-microsoft
Copy link
Contributor

@qingyun-wu informed me that llm_config has been used in the past to set use_cache, but this is not currently documented anywhere. Clear documentation is needed since our ChatCompletion.create method carries a use_cache argument, and users will hit a runtime error if they pass use_cache values through llm_config and directly to ChatCompletion.create at the same time.

@sonichi
Copy link
Contributor

sonichi commented Oct 21, 2023

when will a user write both llm_config and ChatCompletion.create?

@rickyloynd-microsoft
Copy link
Contributor Author

They could do this by accident.

@sonichi
Copy link
Contributor

sonichi commented Oct 21, 2023

The current doc is:

llm_config dict or False - llm inference configuration. Please refer to Completion.create for available options. To disable llm-based auto reply, set to False.

https://microsoft.github.io/autogen/docs/reference/agentchat/conversable_agent#__init__

If any clarification is desired, this is the place.

@sonichi sonichi added the documentation Improvements or additions to documentation label Oct 21, 2023
@thinkall
Copy link
Collaborator

We are closing this issue due to inactivity; please reopen if the problem persists.

jackgerrits pushed a commit that referenced this issue Oct 2, 2024
…323)

* add notebooks for documentation

* Merge remote-tracking branch 'origin/main' into ekzhu-notebooks

* Add install

* Add to checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants