Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend plan interfaces #231

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Extend plan interfaces #231

merged 13 commits into from
Aug 6, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Aug 5, 2024

  • Rename DefaultPlanner as Planner
  • Add PlannerContext interface
  • Add Plan Python class
  • Add Architecture tag in the plan format
  • Minor other interface changes

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 94.46809% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.01%. Comparing base (dad034d) to head (5b29d86).

Files Patch % Lines
ark/model/model_json.cpp 61.53% 5 Missing ⚠️
ark/api/planner.cpp 98.33% 2 Missing ⚠️
ark/context_impl.cpp 91.30% 2 Missing ⚠️
ark/range.cpp 66.66% 2 Missing ⚠️
ark/api/executor.cpp 83.33% 1 Missing ⚠️
ark/model/model_graph_impl.cpp 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   90.72%   91.01%   +0.29%     
==========================================
  Files         102      106       +4     
  Lines        3923     4106     +183     
==========================================
+ Hits         3559     3737     +178     
- Misses        364      369       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chhwang chhwang merged commit 6ae63be into main Aug 6, 2024
9 of 10 checks passed
@chhwang chhwang deleted the chhwang/plan_context branch August 6, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant