Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json output for an error #1278

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Fix json output for an error #1278

merged 4 commits into from
Feb 15, 2021

Conversation

russelarms
Copy link
Contributor

@russelarms russelarms commented Feb 15, 2021

This PR fixes an output when an error occurs and --output json has been specified.

Before:

appcenter distribute release -f release.apk --output json
Error: At least one of '--group' or '--store' must be specified

After:

appcenter distribute release -f release.apk --output json
{"succeeded":false,"errorCode":4,"errorMessage":"At least one of '--group' or '--store' must be specified"}

Aside from that it:

  • improves the Distribute functional test
  • fixes Distribute release notes error message

Related issues:
#1207
#768
AB#84915

@russelarms russelarms merged commit 1e970ce into master Feb 15, 2021
@russelarms russelarms deleted the fix/error-json-output branch February 15, 2021 10:18
@ahujamanish
Copy link

@russelarms thanks for the fix. Do we know when is a new appcenter-cli release coming with the above updates?

@MatkovIvan
Copy link
Contributor

MatkovIvan commented Mar 1, 2021

Hi @ahujamanish,
There is no specific ETA. We're planning to batch a few more fixes to the release.

@ahujamanish
Copy link

ahujamanish commented Mar 17, 2021

@MatkovIvan I see that a new release went out yesterday but I'm still seeing the issue.

appcenter distribute release -f xxxx.ipa --release-notes 'release_notes' -g 'Collaborators' --app 'org/app' --output json

results in

Error: failed to create release upload for xxxx.ipa. Not found. Correlation ID: 3954a953-a41d-4603-ac01-4xxxxxxx

I'm on version 2.8.1

@russelarms
Copy link
Contributor Author

@ahujamanish thanks for pointing that out, it's a bug. We'll fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants