Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy variables support to appcenter-file-upload-client-node #1044

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

russelarms
Copy link
Contributor

@russelarms russelarms commented Sep 2, 2020

This PR adds proxy environment variables support to appcenter-file-upload-client-node using proxy-agent package. It should fix the problem with uploading releases using a proxy.
This PR also bumps the package version. After the PR is reviewed and tested we should publish an update to npmjs and update the dependency of the appcenter-cli and use the new fetchWithOptions method instead of 'fetch'. There's a draft PR for it.

How to test:

  1. Add an environment variable 'https_proxy' with proxy settings.
export https_proxy=http://xx.xx.xx.xx:port
  1. cd appcenter-file-upload-client-node && npm pack
  2. install the package from the previous step in appcenter-cli
  3. change fetch calls with fetchWithOptions from "appcenter-file-upload-client-node". See this PR.
  4. run upload release command. E.g. appcenter distribute release -f appRelease.apk -g publicGroupName

Tested:

  • http and https proxy tested manually
  • with npm test and npm test:ci
  • ci tests

Related links:
Original issue: #982
The next PR: #1045
AB#81897

annakocheshkova
annakocheshkova previously approved these changes Sep 2, 2020
Copy link

@annakocheshkova annakocheshkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, not tested though.

Copy link
Contributor

@jp-andre jp-andre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me, but there's no test verifying that an agent is set when the env var is set.

appcenter-file-upload-client-node/package.json Outdated Show resolved Hide resolved
appcenter-file-upload-client-node/src/ac-fus-util.ts Outdated Show resolved Hide resolved
@russelarms
Copy link
Contributor Author

Looks go to me, but there's no test verifying that an agent is set when the env var is set.

Added a simple test.

@jp-andre jp-andre merged commit 38365d0 into master Sep 4, 2020
@jp-andre jp-andre deleted the v-ruurme/node-fetch-proxy branch September 4, 2020 07:51
anywherepilot pushed a commit that referenced this pull request Sep 24, 2020
Updates **appcenter-file-upload-client-node** dependency and applies the new 'fetchWithOptions' method from #1044.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout while publishing app to appcenter
3 participants