-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy variables support to appcenter-file-upload-client-node #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, not tested though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go to me, but there's no test verifying that an agent is set when the env var is set.
Added a simple test. |
Updates **appcenter-file-upload-client-node** dependency and applies the new 'fetchWithOptions' method from #1044.
This PR adds proxy environment variables support to appcenter-file-upload-client-node using proxy-agent package. It should fix the problem with uploading releases using a proxy.
This PR also bumps the package version. After the PR is reviewed and tested we should publish an update to npmjs and update the dependency of the appcenter-cli and use the new
fetchWithOptions
method instead of 'fetch'. There's a draft PR for it.How to test:
cd appcenter-file-upload-client-node && npm pack
appcenter-cli
fetch
calls withfetchWithOptions
from "appcenter-file-upload-client-node". See this PR.appcenter distribute release -f appRelease.apk -g publicGroupName
Tested:
Related links:
Original issue: #982
The next PR: #1045
AB#81897