Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update binskim to optout 4.3.1 version #1903

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

v-sharmachir
Copy link
Contributor

Details

This is new pre release version used in 1ES pipeline templates. But our TSA upload task still uses the older version (1.9.5) so this conflict is resulting into pipeline failure.

For now updating pipeline to optout for new version.

Motivation
Context

There will be separate work item to update binskim to 4.3.1 version as new rules in 4.3.1 might discover issues which also need to be resolved so that pipeline does not break.

Pull request checklist

  • Run through of all test scenarios completed?
  • Does this address an existing issue? If yes, Issue# -
  • Includes UI changes?
    • Run the production version of Accessibility Insights for Windows against a version with changes.
    • Attach any screenshots / GIF's that are applicable.

Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.

@v-viyada v-viyada marked this pull request as ready for review December 2, 2024 19:43
@v-viyada v-viyada requested a review from a team as a code owner December 2, 2024 19:43
@v-viyada v-viyada merged commit 54d160c into main Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants