Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme for E2E behavior on WSL #856

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

Shobhit1
Copy link
Contributor

Description of changes

Update Readme to have a specific PS note linking to the issue that I created for running E2E on WSL.

Pull request checklist

  • Addresses an existing issue: Fixes E2E tests not running on Ubuntu/WSL #853
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
yihuang yihuang
@Shobhit1 Shobhit1 added the pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay. label Jun 25, 2019
@Shobhit1 Shobhit1 requested a review from a team June 25, 2019 18:29
@Shobhit1 Shobhit1 self-assigned this Jun 25, 2019
@msft-github-bot
Copy link
Collaborator

Hello @Shobhit1!

Because this pull request has the pr: auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

README.md Outdated Show resolved Hide resolved
@msft-github-bot msft-github-bot merged commit 247d205 into microsoft:master Jun 25, 2019
@Shobhit1 Shobhit1 deleted the update-readme-e2e branch July 5, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests not running on Ubuntu/WSL
4 participants