-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Left nav lacks clear tab or focus indicators with Windows HC modes #7311
base: main
Are you sure you want to change the base?
fix: Left nav lacks clear tab or focus indicators with Windows HC modes #7311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is functional, but I find that the hover styles in contrast themes are nausea-inducing. Could we implement it closer to how it is in the default theme where we change the background color on hover? Or maybe underline the button text?
@nang4ally what do you think?
I remember, we discussed about this in one of standup meeting and finalized only to outline for hover style which is similar to windows file explorer in high contrast but we can still change if this does not look as required. Btw we have limited color selection in contrast themes. Below are the color options in aquatic theme and users can change them according to their choice. |
I believe the new directive is to change the left nav item's background color on hover, and also to add text underline on hover to all links (e.g. on the Getting Started and Overview pages in Assessment). @nang4ally can you add/amend anything I missed? |
Agree with Madalyn- that is what we agreed on with the Design call. This is a summary of what we decided:
|
HI @madalynrose |
Details
Fixed the Color contrast issue of focus for left nav tab for high contrast theme.
Added underlines for links as per the requirement.
Motivation
Addresses Issue - Left nav lacks clear tab or focus indicators with Windows HC modes
Context
Theme - Desert
Theme - Aquatic
Theme - Dusk
Theme - Night Sky
Screenshots of added underlines upon hover are pasted as below-
Theme - None
Theme - Aquatic
Theme - Desert
Theme - Dusk
Theme - Night Sky
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.