Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TypeScript Cleanup 5.0 Part 4 for Errors - includeStepsText,featureFlagStoreData,deps,requirementState,outline, #7292

Merged
merged 9 commits into from
Apr 11, 2024
Merged

chore: TypeScript Cleanup 5.0 Part 4 for Errors - includeStepsText,featureFlagStoreData,deps,requirementState,outline, #7292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db5e35d
TypeScript Changes cleanup 2.0
JeevaniChinthala Apr 1, 2024
0ffd04b
Updated Snapshot for details-view-command-bar file
JeevaniChinthala Apr 2, 2024
ce1d17e
Worked on PR review comments
v-prachin Apr 5, 2024
67e15c3
Updated the testcase for deps property
JeevaniChinthala Apr 8, 2024
91aac64
added verifiable
JeevaniChinthala Apr 8, 2024
fff0a64
Format fix
JeevaniChinthala Apr 8, 2024
815b4d2
removed includeStepsText
JeevaniChinthala Apr 10, 2024
3d2d4a7
removed unsused includeStepsText property
JeevaniChinthala Apr 10, 2024
0210d1b
Added includeStepsText
JeevaniChinthala Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/DetailsView/components/default-test-view-container-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export class DefaultTestViewContainerProvider implements TestViewContainerProvid
instancesSection={FailedInstancesSection}
cardSelectionMessageCreator={props.assessmentCardSelectionMessageCreator}
cardsViewData={props.assessmentCardsViewData}
includeStepsText={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, don't we need these?

selectedVisualizationType={
props.assessmentStoreData?.assessmentNavState?.selectedTestType
}
Expand Down
1 change: 0 additions & 1 deletion ...s/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`DefaultTestViewContainerProvider can create assessment automated checks
automatedChecksCardsViewData={{}}
cardSelectionMessageCreator={{}}
cardsViewData={{}}
includeStepsText={false}
instancesSection={[Function]}
needsReviewCardSelectionMessageCreator={{}}
needsReviewCardsViewData={{}}
Expand Down
Loading