Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TypeScript Cleanup 5.0 Part 4 for Errors - includeStepsText,featureFlagStoreData,deps,requirementState,outline, #7292

Merged
merged 9 commits into from
Apr 11, 2024
Merged

chore: TypeScript Cleanup 5.0 Part 4 for Errors - includeStepsText,featureFlagStoreData,deps,requirementState,outline, #7292

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db5e35d
TypeScript Changes cleanup 2.0
JeevaniChinthala Apr 1, 2024
0ffd04b
Updated Snapshot for details-view-command-bar file
JeevaniChinthala Apr 2, 2024
ce1d17e
Worked on PR review comments
v-prachin Apr 5, 2024
67e15c3
Updated the testcase for deps property
JeevaniChinthala Apr 8, 2024
91aac64
added verifiable
JeevaniChinthala Apr 8, 2024
fff0a64
Format fix
JeevaniChinthala Apr 8, 2024
815b4d2
removed includeStepsText
JeevaniChinthala Apr 10, 2024
3d2d4a7
removed unsused includeStepsText property
JeevaniChinthala Apr 10, 2024
0210d1b
Added includeStepsText
JeevaniChinthala Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/DetailsView/components/adhoc-tab-stops-test-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ export const AdhocTabStopsTestView = NamedFC<AdhocTabStopsTestViewProps>(
<TabStopsFailedInstancePanel
deps={props.deps}
failureInstanceState={props.tabStopsViewStoreData.failureInstanceState}
requirementState={requirementState}
/>

<FocusComponent deps={props.deps} tabbingEnabled={scanData.enabled} />
Expand Down
1 change: 1 addition & 0 deletions src/DetailsView/components/assessment-issues-test-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export type AssessmentIssuesTestViewDeps = {
export type AssessmentIssuesTestViewProps = {
deps: AssessmentIssuesTestViewDeps;
assessmentStoreData: AssessmentStoreData;
includeStepsText?: boolean;
JeevaniChinthala marked this conversation as resolved.
Show resolved Hide resolved
} & Omit<AdhocIssuesTestViewProps, 'deps'>;

export class AssessmentIssuesTestView extends React.Component<AssessmentIssuesTestViewProps> {
Expand Down
6 changes: 1 addition & 5 deletions src/DetailsView/components/left-nav/details-view-left-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,7 @@ export const DetailsViewLeftNav = NamedFC<DetailsViewLeftNavProps>('DetailsViewL

const leftNav: JSX.Element = (
<div className={`${styles.leftNav} main-nav`}>
<Switcher
deps={props.deps}
featureFlagStoreData={featureFlagStoreData}
pivotKey={props.selectedPivot}
/>
<Switcher deps={props.deps} pivotKey={props.selectedPivot} />
v-prachin marked this conversation as resolved.
Show resolved Hide resolved
<switcherNavConfiguration.LeftNav
deps={deps}
assessmentsProvider={filteredProvider}
Expand Down
3 changes: 1 addition & 2 deletions src/DetailsView/components/report-export-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,10 @@ export class ReportExportComponent extends React.Component<
};

public render(): JSX.Element {
const { deps, reportExportFormat, isOpen, featureFlagStoreData } = this.props;
const { reportExportFormat, isOpen, featureFlagStoreData } = this.props;

return (
<ExportDialog
deps={deps}
v-prachin marked this conversation as resolved.
Show resolved Hide resolved
isOpen={isOpen}
htmlFileName={this.state.htmlExportName}
jsonFileName={this.state.jsonExportName}
Expand Down
2 changes: 0 additions & 2 deletions src/injected/visualization/accessible-names-formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,9 @@ export class AccessibleNamesFormatter implements Formatter {
text: formattedAccessibleName,
fontWeight: '400',
fontSize: '10px',
outline: '3px dashed',
v-prachin marked this conversation as resolved.
Show resolved Hide resolved
},
outlineColor: AccessibleNamesFormatter.style.outlineColor,
outlineStyle: 'dashed',
outlineWidth: '3px',
v-prachin marked this conversation as resolved.
Show resolved Hide resolved
showVisualization: true,
};
return config;
Expand Down
1 change: 0 additions & 1 deletion src/popup/components/launch-panel-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export class LaunchPanelHeader extends React.Component<
deps={this.props.deps}
popupWindow={this.props.popupWindow}
header={this}
featureFlagData={featureFlags}
/>
</>
);
Expand Down
1 change: 0 additions & 1 deletion src/popup/handlers/launch-panel-header-click-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export class LaunchPanelHeaderClickHandler {
public onOpenContextualMenu(header: LaunchPanelHeader, event: React.MouseEvent<any>): void {
header.setState({
target: event.currentTarget,
isContextMenuVisible: true,
});
}

Expand Down
6 changes: 1 addition & 5 deletions src/reports/components/fast-pass-report.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ export const FastPassReport = NamedFC<FastPassReportProps>('FastPassReport', pro
<ContentContainer>
<FastPassTitleSection />
<DetailsSection {...props} />
<FastPassReportSummary
{...props}
featureFlagStoreData={props.deps.featureFlagStoreData}
/>
<FastPassReportSummary {...props} />
<ResultsContainer {...props}>
<FastPassResultsTitleSection title="Automated checks" />
<FastPassReportAutomatedChecksResults {...props} />
Expand All @@ -66,7 +63,6 @@ export const FastPassReport = NamedFC<FastPassReportProps>('FastPassReport', pro
tabStopsTestViewController: undefined,
...props.deps,
}}
featureFlagStoreData={props.deps.featureFlagStoreData}
tabStopRequirementState={props.results.tabStops}
alwaysRenderSection={true}
/>
Expand Down
1 change: 0 additions & 1 deletion src/reports/components/report-sections/collapsible-url-result-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const CollapsibleUrlResultSection = NamedFC<CollapsibleUrlResultSectionPr
header: <ResultSectionTitle {...props} titleSize="heading" />,
content,
headingLevel: 3,
deps: null,
});

return <div className={styles.urlResultSection}>{CollapsibleContent}</div>;
Expand Down
17 changes: 0 additions & 17 deletions ...ts/unit/tests/DetailsView/components/__snapshots__/details-view-command-bar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ exports[`DetailsViewCommandBar renders invalid load assessment dialog: invalid l
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -244,7 +243,6 @@ exports[`DetailsViewCommandBar renders invalid load assessment dialog: invalid l
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -400,7 +398,6 @@ exports[`DetailsViewCommandBar renders load assessment dialog: load assessment d
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -556,7 +553,6 @@ exports[`DetailsViewCommandBar renders load assessment dialog: load assessment d
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -685,7 +681,6 @@ exports[`DetailsViewCommandBar renders report export dialog: export dialog hidde
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -814,7 +809,6 @@ exports[`DetailsViewCommandBar renders report export dialog: export dialog open
</button>
</div>
<mock-exportdialog
deps="[object Object]"
featureflagstoredata="[object Object]"
htmlexportdata=""
htmlfilename="Assessment_20240307_commandbartesttabtit.html"
Expand Down Expand Up @@ -979,7 +973,6 @@ exports[`DetailsViewCommandBar renders start assessment over dialog: start asses
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1142,7 +1135,6 @@ exports[`DetailsViewCommandBar renders start assessment over dialog: start asses
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1308,7 +1300,6 @@ exports[`DetailsViewCommandBar renders start test over dialog: start test over d
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1471,7 +1462,6 @@ exports[`DetailsViewCommandBar renders start test over dialog: start test over d
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1603,7 +1593,6 @@ exports[`DetailsViewCommandBar renders transfer to assessment dialog: transfer t
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1735,7 +1724,6 @@ exports[`DetailsViewCommandBar renders transfer to assessment dialog: transfer t
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1834,7 +1822,6 @@ exports[`DetailsViewCommandBar renders with buttons collapsed into a menu 1`] =
</div>
<mock-commandbarbuttonsmenu />
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -1975,7 +1962,6 @@ exports[`DetailsViewCommandBar renders with export button and start over 1`] = `
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -2084,7 +2070,6 @@ exports[`DetailsViewCommandBar renders with export button, without start over 1`
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -2192,7 +2177,6 @@ exports[`DetailsViewCommandBar renders without export button and without start o
</div>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down Expand Up @@ -2321,7 +2305,6 @@ exports[`DetailsViewCommandBar renders without export button, with start over 1`
</button>
</div>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down
5 changes: 0 additions & 5 deletions ...sts/unit/tests/DetailsView/components/__snapshots__/report-export-component.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
exports[`ReportExportComponent clicking export on the dialog triggers generateExports, generates json and html with the current exportDescription 1`] = `
<DocumentFragment>
<mock-exportdialog
deps="[object Object]"
description="test content with special characters: <> $ " \` '"
featureflagstoredata="[object Object]"
htmlexportdata="test html"
Expand All @@ -22,7 +21,6 @@ exports[`ReportExportComponent clicking export on the dialog triggers generateEx
exports[`ReportExportComponent edit text field: test content with special characters: <> $ " \` ' 1`] = `
<DocumentFragment>
<mock-exportdialog
deps="[object Object]"
description="test content with special characters: <> $ " \` '"
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand All @@ -41,7 +39,6 @@ exports[`ReportExportComponent edit text field: test content with special charac
exports[`ReportExportComponent on dialog opened 1`] = `
<DocumentFragment>
<mock-exportdialog
deps="[object Object]"
description="export description"
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand All @@ -59,7 +56,6 @@ exports[`ReportExportComponent on dialog opened 1`] = `
exports[`ReportExportComponent render with dialog closed 1`] = `
<DocumentFragment>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand All @@ -78,7 +74,6 @@ exports[`ReportExportComponent render with dialog closed 1`] = `
exports[`ReportExportComponent render with dialog open 1`] = `
<DocumentFragment>
<mock-exportdialog
deps="[object Object]"
description=""
featureflagstoredata="[object Object]"
htmlexportdata=""
Expand Down
2 changes: 0 additions & 2 deletions ...t/tests/DetailsView/components/left-nav/__snapshots__/details-view-left-nav.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ exports[`DetailsViewLeftNav should render from switcher nav 1`] = `
>
<mock-switcher
deps="[object Object]"
featureflagstoredata="[object Object]"
/>
<mock-assessmentleftnav
assessmentsdata="[object Object]"
Expand Down Expand Up @@ -44,7 +43,6 @@ exports[`DetailsViewLeftNav should render from switcher nav: Switcher props 1`]
"assessmentsProviderWithFeaturesEnabled": [Function],
"getProvider": [Function],
},
"featureFlagStoreData": {},
"pivotKey": undefined,
}
`;
1 change: 0 additions & 1 deletion src/tests/unit/tests/assessments/common/analyzer-configuration-factory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { ScannerUtils } from '../../../../../injected/scanner-utils';

const baseConfig: Readonly<Partial<RuleAnalyzerConfiguration>> = {
key: 'test-key',
testName: 'test-name',
rules: ['rule-1', 'rule-2'],
testType: -1 as VisualizationType,
};
Expand Down
Loading
Loading