Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Typescript Cleanup Part 2 of 3 for selector, isEnabled, requirementLink, leftNavLinkBuilder & height:0 #7276

Merged
merged 4 commits into from
Apr 1, 2024
Merged

chore: Typescript Cleanup Part 2 of 3 for selector, isEnabled, requirementLink, leftNavLinkBuilder & height:0 #7276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44b2488
Typescript Cleanup New errors
v-prachin Mar 18, 2024
3585c16
Removed comments
v-prachin Mar 18, 2024
c13699a
Merge branch 'microsoft:main' into typescript-new-errors
v-prachin Mar 18, 2024
05db81a
Merge branch 'microsoft:main' into typescript-new-errors
v-prachin Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/assessments/automated-checks/build-test-steps-from-rules.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ function buildAutomatedCheckStep(rule: ScannerRuleInfo): Requirement {
getInstanceStatus: getInstanceStatus,
getInstanceStatusColumns: () => [],
instanceTableHeaderType: 'none',
renderRequirementDescription: requirementLink =>
requirementLink.renderRequirementDescriptionWithoutIndex(),
getDefaultMessage: defaultMessageGenerator =>
defaultMessageGenerator.getNoFailingInstanceMessage,
getVisualHelperToggle: props => <AutomatedChecksVisualizationToggle {...props} />,
Expand Down
1 change: 1 addition & 0 deletions src/assessments/types/iassessment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ interface BaseAssessment {
extensions?: AnyExtension[];
initialDataCreator?: InitialDataCreator;
isNonCollapsible?: boolean;
isEnabled?: boolean;
}

export interface ManualAssessment extends BaseAssessment {}
Expand Down
1 change: 1 addition & 0 deletions src/common/types/store-data/assessment-result-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export interface GeneratedAssessmentInstance<T = {}, K = {}> {
html: string;
testStepResults: AssessmentResultType<K>;
propertyBag?: T;
selector?: string;
}

export interface TestStepResult {
Expand Down
3 changes: 0 additions & 3 deletions src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,12 @@ describe(AssessmentLeftNav.displayName, () => {
props = {
deps,
selectedKey: 'some key',
leftNavLinkBuilder: leftNavLinkBuilderMock.object,
assessmentsProvider: assessmentsProviderStub,
assessmentsData: assessmentsDataStub,
featureFlagStoreData: {},
expandedTest,
onRightPanelContentSwitch,
setNavComponentRef,
getAssessmentSummaryModelFromProviderAndStatusData:
getAssessmentSummaryModelFromProviderAndStatusDataMock.object,
};

leftNavLinkBuilderMock
Expand Down
1 change: 0 additions & 1 deletion src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ describe(QuickAssessLeftNav.displayName, () => {
props = {
deps,
selectedKey: 'some key',
leftNavLinkBuilder: leftNavLinkBuilderMock.object,
assessmentsProvider: assessmentsProviderStub,
assessmentsData: assessmentsDataStub,
featureFlagStoreData: {},
Expand Down
1 change: 0 additions & 1 deletion src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ describe('VisualizationBasedLeftNav', () => {
props = {
deps,
selectedKey: 'some key',
leftNavLinkBuilder: leftNavLinkBuilderMock.object,
onLinkClick: onLinkClickStub,
visualizations: visualizationsStub,
onRightPanelContentSwitch,
Expand Down
1 change: 0 additions & 1 deletion src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ describe(NarrowModeDetector, () => {
expect(
renderFunc({
width: narrowModeThresholds.collapseHeaderAndNavThreshold - 1,
height: 0,
}),
).toMatchSnapshot('All narrow mode status values should be false');
});
Expand Down
Loading