Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wcag-2-2): Deprecate parsing assessment for WCAG 2.2 #7068

Merged
merged 3 commits into from
Nov 2, 2023
Merged

feat(wcag-2-2): Deprecate parsing assessment for WCAG 2.2 #7068

merged 3 commits into from
Nov 2, 2023

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Nov 1, 2023 •
edited by madalynrose
Loading

Details

This PR adds a "Deprecated for WCAG 2.2" notice to the "parsing" assessment.

screenshot of the Parsing assessment with the new "Deprecated for WCAG 2.2" pill next to it

Motivation

Part of the WCAG 2.2 feature (available internally on Azure DevOps).

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@codeofdusk codeofdusk requested a review from a team as a code owner November 1, 2023 22:11
madalynrose
madalynrose requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording change and updating report e2e tests (yarn test:report:e2e -u) and then this is good to go!

src/common/types/store-data/guidance-links.ts Outdated Show resolved Hide resolved
@codeofdusk codeofdusk merged commit ea73258 into microsoft:main Nov 2, 2023
12 checks passed
codeofdusk added a commit to codeofdusk/accessibility-insights-web that referenced this pull request Aug 12, 2024
@codeofdusk
Revert "feat(wcag-2-2): Deprecate parsing assessment for WCAG 2.2 (mi…
8220844 
…crosoft#7068)"

This assessment will be removed, so remove the supporting deprecation notice.

This reverts commit ea73258.
codeofdusk added a commit to codeofdusk/accessibility-insights-web that referenced this pull request Sep 23, 2024
@codeofdusk
Revert "feat(wcag-2-2): Deprecate parsing assessment for WCAG 2.2 (mi…
9c8030c 
…crosoft#7068)"

This assessment will be removed, so remove the supporting deprecation notice.

This reverts commit ea73258.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madalynrose madalynrose madalynrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codeofdusk @madalynrose