-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wcag-2-2): Add "dragging movements" test #7058
feat(wcag-2-2): Add "dragging movements" test #7058
Conversation
interprets pointer actions (i.e. this does not apply to actions that are required to | ||
operate the user agent or assistive technology). | ||
</p> | ||
<ManualTestRecordYourResults isMultipleFailurePossible={true} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this markup okay? NVDA is acting like this creates a <li>
element (should it be inside a list?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at one of the other test steps for pointer motion, (e.g., Motion operation), you'll see that the "Exception" paragraph is part of the <li>
before it, and that the ManualTestRecordYourResults
component is inside the <ol>
since it does create a <li>
element. Once this matches that formatting, NVDA should be happier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing you are missing is adding the content for this test to the index of links for pointer motion (src/content/test/pointer-motion/index.ts). That will make the content available to the test step and display the info-examples button to open the side panel.
I added a comment about formatting on the file itself, but other than these two changes it looks great!
interprets pointer actions (i.e. this does not apply to actions that are required to | ||
operate the user agent or assistive technology). | ||
</p> | ||
<ManualTestRecordYourResults isMultipleFailurePossible={true} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at one of the other test steps for pointer motion, (e.g., Motion operation), you'll see that the "Exception" paragraph is part of the <li>
before it, and that the ManualTestRecordYourResults
component is inside the <ol>
since it does create a <li>
element. Once this matches that formatting, NVDA should be happier.
@madalynrose Other items in the Pointer assessment are represented in the e2e test snapshots (link). Is there something special that needs to happen to make this occur in the e2e tests? |
src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update links to match other requirements
Co-authored-by: Madalyn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Details
This PR adds "dragging movements" to the assessment experience.
Motivation
Part of Feature 2100304 (internal access required to view).
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.